Skip to content

[Cohost] Fix rename and unskip test #11952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 17, 2025
Merged

[Cohost] Fix rename and unskip test #11952

merged 6 commits into from
Jul 17, 2025

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Jun 16, 2025

Fixes #11831

This needs dotnet/roslyn#78984 to go in first, or the test will fail. Which you should see in this PR!

@davidwengier davidwengier mentioned this pull request Jun 16, 2025
Merged
davidwengier added a commit to dotnet/roslyn that referenced this pull request Jul 8, 2025
@davidwengier
Allow rename to (optionally) process source generated documents (#78984)
f2649bb 
Part of dotnet/razor#11831

Razor side that completes the fix is
dotnet/razor#11952

I am _well_ out of my depth with rename, and have commented on a couple
of spots that might be contentious, or are otherwise worth noting.
@davidwengier
Merge remote-tracking branch 'upstream/main' into CohostRename
2fa21e2 
# Conflicts:
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/DocumentMapping/AbstractEditMappingService.cs
#	src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/ProjectSystem/Extensions.cs
@davidwengier
Tweak
3e0ed62
@davidwengier
Bump Roslyn and dependencies
29093b7
@davidwengier
Respond to API obsoletion
e0240cf
@davidwengier davidwengier marked this pull request as ready for review July 17, 2025 00:08
@davidwengier davidwengier requested review from a team as code owners July 17, 2025 00:08
@davidwengier
Copy link
Member Author

davidwengier commented Jul 17, 2025 •
edited
Loading

Roslyn side of this has finally been inserted.

FYI @phil-allen-msft we'll need to take this through M2 nvm, will open a separate PR to target the right branch

@davidwengier davidwengier changed the base branch from main to release/dev-next July 17, 2025 00:15
@davidwengier davidwengier changed the base branch from release/dev-next to main July 17, 2025 00:20
@davidwengier davidwengier mentioned this pull request Jul 17, 2025
Merged
alexgav
alexgav approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit a67c6a7 into dotnet:main Jul 17, 2025
11 checks passed
@davidwengier davidwengier deleted the CohostRename branch July 17, 2025 21:41
davidwengier added a commit that referenced this pull request Jul 17, 2025
@davidwengier
[Cohost] Fix rename (#12036)
e5a74ea 
Fixes #11831

Targeting dev-next for M2 mode. Might supersede
#11952 depending on whether we have
auto-merge or not. Waiting for an answer on that :)
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 17, 2025
@davidwengier davidwengier mentioned this pull request Jul 20, 2025
Merged
@dotnet-bot dotnet-bot mentioned this pull request Jul 26, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexgav alexgav alexgav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

Roslyn doesn't run rename on source generated documents

3 participants

@davidwengier @alexgav @RikkiGibson