Require public component parameters and remove private metadata workaround #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…round - Prior to this a user could have private, protected or public parameters. We now require public and plan to update analyzers to enforce good usage of public component parameters. - Removed private `ComponentTagHelperDescriptorProvider` workaround. meta data workaround since we no longer operate on private parameters. - Updated existing tests to not have private parameter setters. I missed these in my last pass. - Added two new tests to validate parameters which are private or have private setters are ignored. dotnet/aspnetcore#12291
NTaylorMullen
commented
Jul 30, 2019
| @@ -333,6 +317,7 @@ private void CreateContextParameter(TagHelperDescriptorBuilder builder, string c | |||
| // a dictionary keyed on property name. | |||
| // | |||
| // We consider parameters to be defined by properties satisfying all of the following: | |||
| // - are public | |||
There was a problem hiding this comment.
Requiring public wasn't initially mentioned in the component visibility issue but it felt "more right" to me in an effort to default to being more restrictive for RTM to avoid edge cases. Not to mention it'll be an analyzer error by default. Let me know if you feel differently.
rynowak
approved these changes
Jul 31, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentTagHelperDescriptorProviderworkaround. meta data workaround since we no longer operate on private parameters.dotnet/aspnetcore#12291