Skip to content

Conversation

@bartdesmet
Copy link
Collaborator

Check if the CI build does already support C# 9.0 features. If so, conversion to static lambdas (to help identify cases where we have unexpected or avoidable closures) can continue.

@bartdesmet
Copy link
Collaborator Author

First pass over a subset of the code, while addressing a few unnecessary closures in the process. Future PRs will continue this work:

  1. Mark more existing lambdas as static where possible.
  2. Try to convert closure-capturing lambdas to static where possible and worthwhile.
  3. Optionally annotating the non-static lambdas with a clear indicator of a closure (/* closure */) so these can be easily CTRL-F'd.

@bartdesmet
Copy link
Collaborator Author

Possible flaky test to be investigated:

EventLoop_ScheduleTimeAndOrderedInFlightActions

@bartdesmet bartdesmet merged commit 860b383 into main Sep 30, 2020
@bartdesmet bartdesmet deleted the dev/bartde/static_lambdas branch September 30, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants