Skip to content

More trivial nullable goodness. #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartdesmet merged 1 commit into from
Oct 1, 2020
Merged

More trivial nullable goodness. #1343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rx.NET/Source/src/System.Reactive/Concurrency/LocalScheduler.TimerQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ private static void EvaluateLongTermQueue()
/// </summary>
/// <param name="args">Currently not used.</param>
/// <param name="sender">Currently not used.</param>
internal virtual void SystemClockChanged(object sender, SystemClockChangedEventArgs args)
internal virtual void SystemClockChanged(object? sender, SystemClockChangedEventArgs args)
{
lock (StaticGate)
{
Expand Down
4 changes: 1 addition & 3 deletions Rx.NET/Source/src/System.Reactive/Concurrency/Synchronization.Synchronize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Concurrency
{
internal sealed class Synchronize<TSource> : Producer<TSource, Synchronize<TSource>._>
{
private readonly IObservable<TSource> _source;
private readonly object _gate;
private readonly object? _gate;

public Synchronize(IObservable<TSource> source, object gate)
{
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/All.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class All<TSource> : Producer<bool, All<TSource>._>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Any.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal static class Any<TSource>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/AsObservable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class AsObservable<TSource> : Producer<TSource, AsObservable<TSource>._>, IEvaluatableObservable<TSource>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Contains.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

using System.Collections.Generic;

namespace System.Reactive.Linq.ObservableImpl
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Count.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal static class Count<TSource>
Expand Down
10 changes: 4 additions & 6 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/ForEach.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

using System.Threading;

namespace System.Reactive.Linq.ObservableImpl
Expand All @@ -15,7 +13,7 @@ public sealed class Observer : IObserver<TSource>
private readonly Action<TSource> _onNext;
private readonly Action _done;

private Exception _exception;
private Exception? _exception;
private int _stopped;

public Observer(Action<TSource> onNext, Action done)
Expand All @@ -24,7 +22,7 @@ public Observer(Action<TSource> onNext, Action done)
_done = done;
}

public Exception Error => _exception;
public Exception? Error => _exception;

public void OnNext(TSource value)
{
Expand Down Expand Up @@ -65,7 +63,7 @@ public sealed class ObserverIndexed : IObserver<TSource>
private readonly Action _done;

private int _index;
private Exception _exception;
private Exception? _exception;
private int _stopped;

public ObserverIndexed(Action<TSource, int> onNext, Action done)
Expand All @@ -74,7 +72,7 @@ public ObserverIndexed(Action<TSource, int> onNext, Action done)
_done = done;
}

public Exception Error => _exception;
public Exception? Error => _exception;

public void OnNext(TSource value)
{
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/IgnoreElements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class IgnoreElements<TSource> : Producer<TSource, IgnoreElements<TSource>._>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/IsEmpty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class IsEmpty<TSource> : Producer<bool, IsEmpty<TSource>._>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/LongCount.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal static class LongCount<TSource>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/OfType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class OfType<TSource, TResult> : Producer<TResult, OfType<TSource, TResult>._>
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Sum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class SumDouble : Producer<double, SumDouble._>
Expand Down
6 changes: 2 additions & 4 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Synchronize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

namespace System.Reactive.Linq.ObservableImpl
{
internal sealed class Synchronize<TSource> : Producer<TSource, Synchronize<TSource>._>
{
private readonly IObservable<TSource> _source;
private readonly object _gate;
private readonly object? _gate;

public Synchronize(IObservable<TSource> source, object gate)
{
Expand All @@ -30,7 +28,7 @@ internal sealed class _ : IdentitySink<TSource>
{
private readonly object _gate;

public _(object gate, IObserver<TSource> observer)
public _(object? gate, IObserver<TSource> observer)
: base(observer)
{
_gate = gate ?? new object();
Expand Down
2 changes: 0 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Timestamp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// The .NET Foundation licenses this file to you under the MIT License.
// See the LICENSE file in the project root for more information.

#nullable disable

using System.Reactive.Concurrency;

namespace System.Reactive.Linq.ObservableImpl
Expand Down