Enable #nullable for disposable utils. #1388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more bit of
#nullablesupport. All of the helpers forIDisposableoperations are rather gnarly given their excessive use ofrefbecause of the underlyingVolatileandInterlockedoperations. Luckily we can flow nullable analysis through this using various attributes. In particular:ref(which could beinif the underlying APIs were to usein) can be annotated to ensure null-invariance;refcan be annotated to inherit their null-ness from the value being assigned.