4.x: Inline AnonymousObserver use at places #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// to be disposed upon termination. | ||
| /// </summary> | ||
| /// <typeparam name="T">The element type of the sequence.</typeparam> | ||
| internal sealed class ObserverWithToken<T> : IObserver<T> |
Collaborator
There was a problem hiding this comment.
Can you relate that to AnonymousSafeObserver and SafeObserver and evaluate whether we can save some code/inherit/reuse/etc. here ?
Collaborator
Author
There was a problem hiding this comment.
Those have safeguards and need a disposable upfront. This is just relaying events and calling dispose on the resource.
Collaborator
There was a problem hiding this comment.
Yes, but they are internal and might be reworked to not need the disposable upfront. That way, even the SingleAssignmentDisposable in Producer could be saved. The would just have to expose some interface, e.g. ISafeObserver
Collaborator
Author
There was a problem hiding this comment.
You can try that after this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline the use of
AnonymousObserverat various locations:SubscribewithCancellationTokenSourceSubscribe.Also make
Notification.OnCompletedNotificationstatic singleton; it is stateless so there is no reason to create an instance of it all the time.