An allocation in BasicProducer.SubscribeRaw can be saved in most cases. #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
Jun 18, 2018
danielcweber
commented
Jun 18, 2018
| } | ||
|
|
||
| if (CurrentThreadScheduler.IsScheduleRequired) | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
@akarnokd Can you please review again, it occured to me that on this path, the safeObserver is not assigned the resource. I guess I may have introduced a bug here.
akarnokd
approved these changes
Jun 18, 2018
Collaborator
akarnokd
left a comment
akarnokd
left a comment
There was a problem hiding this comment.
It just skipped the safeObserver without affecting the dispose path. The unit tests usually fail when you make a mistake with the dispose chains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.