Less allocations in SubscribeOnCtxObservable #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinmars
approved these changes
Jun 24, 2018
| { | ||
| Disposable.SetSingle(ref @this._cancel, new ContextDisposable(@this._context, @this._source.SubscribeSafe(@this._observer))); | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Maybe you can convert the lambda into a method. I find the code with all the @this hard to read.
Collaborator
Author
There was a problem hiding this comment.
I couldn't come up with another name that would capture that we're really dealling with this. I could change it. I would, however, not like to remove the lambda because apart from that, it makes for good readability IMO. We could pass a method group instead but due to this, that would cost an allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.