4.x: Improve PushPullAdapter+Sink dispose management #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var res = Run(d); | ||
| d.Disposable = _source.SubscribeSafe(res); | ||
| var res = Run(); | ||
| res.SetUpstream(_source.SubscribeSafe(res)); |
Collaborator
There was a problem hiding this comment.
Please evaluate inheriting PushToPullSink from Sink and using base.Run here.
Collaborator
Author
There was a problem hiding this comment.
Sink is not good here as there is no downstream IObserver to talk to.
danielcweber
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline the
SingleAssignmentDisposableinto thePushPullSink(similar to howSinks were inlined).This PR also includes the logic changes from #667 as the
Collect()operator also uses the push-pull adapter.