Skip to content

Use StableCompositeDisposable.Create for two disposables. #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcweber merged 1 commit into from
Jul 5, 2018
Merged

Use StableCompositeDisposable.Create for two disposables. #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rx.NET/Source/src/System.Reactive/Platforms/UWP/Concurrency/CoreDispatcherScheduler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public override IDisposable Schedule<TState>(TState state, Func<IScheduler, TSta
}
});

return new CompositeDisposable(
return StableCompositeDisposable.Create(
Copy link
Collaborator

@akarnokd akarnokd Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateTrusted?

Copy link
Collaborator Author

@danielcweber danielcweber Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, CreateTrusted takes params that will setup an array. Create with two parameters will go directly to the special case of StableCompositeDisposable.Binary.

Copy link
Collaborator Author

@danielcweber danielcweber Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I already brought up, it might be worth considering up to 16-ary special cases for StableCompositeDisposables for CombineLatest and Zip.

Copy link
Collaborator

@akarnokd akarnokd Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, two arguments only, my mistake.

d,
res.AsDisposable()
);
Expand Down