Fix Zip(IEnumerable) NullReferenceException if a source completes immediately #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweber
approved these changes
Aug 22, 2018
Collaborator
|
Early termination aside, the fact that we wouldn't handle the disposal with TryDispose at that specific location was a bug in its own right, wasn't it? |
Collaborator
Author
|
Yes, a concurrent completion would have potentially experience that null slot too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a source to the
Zipoperator completes immediately before theSubscribeSafereturned, the associated entry in_subscriptionswould be still null, thus theDispose()call fails with aNullReferenceException.The fix checks if the
_subscriptionsis still valid and uses the deferred dispose approach to clean up the indexed entry.