Do not fire 'make member static' when a method references a primary constructor parameter.

[CyrusNajmabadi]

Fixes #6573

[CyrusNajmabadi]

@sharwell @mavasani ptal.

[CyrusNajmabadi]

@mavasani @sharwell , updating to the new roslyn is producing errors like:

Code fix is attempting to provide a fix for a non-local analyzer diagnostic
Expected: False
Actual:   True

It looks like we need to update analyzers here to follow the new rules you set out that diagnostics can only be reported within the span of hte entity we're getting a a callback for.

[mavasani]

@mavasani @sharwell , updating to the new roslyn is producing errors like:

Code fix is attempting to provide a fix for a non-local analyzer diagnostic
Expected: False
Actual:   True

It looks like we need to update analyzers here to follow the new rules you set out that diagnostics can only be reported within the span of hte entity we're getting a a callback for.

Yes, this is a pending work item, see #6560 (comment). However, I don't know if any of the existing tests for this analyzer failed with this issue - @sharwell might know more.

You can disable the non-local diagnostic check with CodeFixTestBehaviors = CodeFixTestBehaviors.SkipLocalDiagnosticCheck just like in the comment above. Fix for #6598 should remove all the usages of CodeFixTestBehaviors.SkipLocalDiagnosticCheck

[mavasani]

Tagging @buyaa-n

@CyrusNajmabadi - do we need to backport this fix to .NET 7 servicing branch? I am not sure if primary constructors are available with compiler shipping in .NET 7 SDK.

[CyrusNajmabadi]

Just to be clear. The "non-local" errors are from other tests. You would still like me to dsiable them?

[CyrusNajmabadi]

Importantly, it looks like there are several hundred tests in this category:

[mavasani]

Importantly, it looks like there are several hundred tests in this category:

Oh that is a huge number. Probably coming from further updates to non-local diagnostics semantics. If your PR is okay to wait till early next week, I can work on this today/tomorrow/over the weekend. If not, feel free to disable non-local diagnostic check for all the failures and merge your PR, I'll try to get to them as soon as possible.

[CyrusNajmabadi]

Sounds good.

[CyrusNajmabadi]

@mavasani can you help update dotnet/roslyn to use this new version of roslyn-analyzers? Thanks!

[cfbao]

Will this be included in the next .NET 8 preview release?