Skip to content

Conversation

@carlossanlop
Copy link

@carlossanlop carlossanlop commented Aug 24, 2023

Similar to the change we did in dotnet/runtime (dotnet/runtime#90812), we need to temporarily switch the OneLocBuild MirrorBranch to point to the release/8.0.1xx branch to ensure all localization changes go there until we ship. This change will be reverted after we ship, so that we point to main again. We need to backport this to the release/8.0.1xx branch as well (like in dotnet/runtime#90813).

@mavasani @sharwell @cristianosuzuki77 @buyaa-n @ericstj @ViktorHofer

@carlossanlop
Copy link
Author

/backport to release/8.0.1xx

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 24, 2023

I doubt the backport GH action is enabled in this repo.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #6890 (a5242e9) into main (7e4877c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6890   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files        1403     1403           
  Lines      330977   330977           
  Branches    10890    10890           
=======================================
+ Hits       319056   319061    +5     
+ Misses       9187     9182    -5     
  Partials     2734     2734           

Copy link

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me, but I don't know how the localizations was working in the branches before, I would wait for approval from @mavasani or @sharwell

@carlossanlop carlossanlop merged commit 4efa61a into dotnet:main Aug 24, 2023
@carlossanlop carlossanlop deleted the OneLocMain branch August 24, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants