Skip to content

Fix color contrast for highlighted item #64843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Oct 19, 2022

Fixes AB#1614420 by keeping the background the same and only using a border for selected items.

Dark Theme

fef7c6fa-ffff-4657-999b-883a69143c92

Light Theme

06931d5e-48e8-4e22-bf1b-0b93c32b5b4c

@ryzngard ryzngard requested a review from a team as a code owner October 19, 2022 22:37
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Oct 19, 2022
@ryzngard ryzngard enabled auto-merge (squash) October 19, 2022 23:12
@ryzngard ryzngard disabled auto-merge October 21, 2022 22:35
@ryzngard ryzngard merged commit b674ba1 into dotnet:main Oct 21, 2022
@ryzngard ryzngard deleted the ste/active_item_contrast branch October 21, 2022 22:35
@ghost ghost added this to the Next milestone Oct 21, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants