Skip to content

Fix case where we were erroneously offering to convert a dictionary to use a collection expression. #75897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 14, 2024
Merged

Fix case where we were erroneously offering to convert a dictionary to use a collection expression. #75897

merged 5 commits into from
Nov 14, 2024

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Nov 13, 2024

Fixes #75894

@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 13, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review November 13, 2024 19:27
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 13, 2024 19:27
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Nov 14, 2024

@JoeRobich ptal. Tnx

ToddGrun
ToddGrun reviewed Nov 14, 2024
View reviewed changes
.../CSharp/Tests/UseCollectionInitializer/UseCollectionInitializerTests_CollectionExpression.cs
void Main()
{
Dictionary<string, string> a = null;
Dictionary<string, string> d = new(a);
Copy link
Contributor

@ToddGrun ToddGrun Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new(a);

dumb question: how does the test know which line it is operating on?

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It analyzes the entire file and reports all the diagnostics it finds. No diagnostics are reported here (hence no annotations in the test markup).

ToddGrun
ToddGrun approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 2a67954 into dotnet:main Nov 14, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the useCollectionInitDict branch November 14, 2024 18:13
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 14, 2024
This was referenced Nov 17, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@akhera99 akhera99 Awaiting requested review from akhera99

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.13 P2

Development

Successfully merging this pull request may close these issues.

Fix occurrence of IDE0028 for a c# Dictionary causes compile error CS9215

3 participants

@CyrusNajmabadi @ToddGrun @jjonescz