Special case inlining a collection expr into a spreaded element #76823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Member
Author
|
@dotnet/roslyn-ide @JoeRobich @ToddGrun ptal |
JoeRobich
reviewed
Jan 21, 2025
Comment on lines
+239
to
+246
| else if (identifier.Parent is ArgumentSyntax | ||
| { | ||
| Parent: TupleExpressionSyntax tupleExpression, | ||
| NameColon: null, | ||
| } argument && | ||
| !SyntaxFacts.IsReservedTupleElementName(identifier.Identifier.ValueText) && | ||
| tupleExpression.Arguments.Count(a => nonConflictReferences.Contains(a.Expression)) == 1) | ||
| { |
Member
There was a problem hiding this comment.
Indentation seems off here.
Suggested change
| else if (identifier.Parent is ArgumentSyntax | |
| { | |
| Parent: TupleExpressionSyntax tupleExpression, | |
| NameColon: null, | |
| } argument && | |
| !SyntaxFacts.IsReservedTupleElementName(identifier.Identifier.ValueText) && | |
| tupleExpression.Arguments.Count(a => nonConflictReferences.Contains(a.Expression)) == 1) | |
| { | |
| else if (identifier.Parent is ArgumentSyntax | |
| { | |
| Parent: TupleExpressionSyntax tupleExpression, | |
| NameColon: null, | |
| } argument && | |
| !SyntaxFacts.IsReservedTupleElementName(identifier.Identifier.ValueText) && | |
| tupleExpression.Arguments.Count(a => nonConflictReferences.Contains(a.Expression)) == 1) | |
| { |
Member
Author
There was a problem hiding this comment.
The Formatter doesn't like that, and gives an ide0055 error :+)
| editor.ReplaceNode( | ||
| spreadElement, | ||
| (_, _) => collectionToInline.Elements.Select( | ||
| e => e.WithLeadingTrivia(leadingTrivia).WithoutTrailingTrivia())); |
Member
There was a problem hiding this comment.
Why do we want to remove trailing trivia here?
Member
Author
There was a problem hiding this comment.
Probably not needed. Will remove!
CyrusNajmabadi
commented
Jan 21, 2025
...s/CSharp/Portable/CodeRefactorings/InlineTemporary/InlineTemporaryCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
…InlineTemporaryCodeRefactoringProvider.cs
CyrusNajmabadi
commented
Jan 21, 2025
| editor.ReplaceNode( | ||
| spreadElement, | ||
| (_, _) => collectionToInline.Elements.Select( | ||
| e => e.WithLeadingTrivia(leadingTrivia).WithoutTrailingTrivia())); |
Member
Author
There was a problem hiding this comment.
Suggested change
| e => e.WithLeadingTrivia(leadingTrivia).WithoutTrailingTrivia())); | |
| e => e.WithLeadingTrivia(leadingTrivia))); |
JoeRobich
approved these changes
Jan 21, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73148