Store client's version for open docs in LSP#80064
Merged
dibarbet merged 2 commits intodotnet:mainfrom Sep 6, 2025
Merged
Conversation
dibarbet
force-pushed
the
store_lsp_version
branch
from
2466b47 to
2782ae6
Compare
dibarbet
force-pushed
the
store_lsp_version
branch
from
2782ae6 to
aa1eb05
Compare
|
|
||
| namespace Microsoft.CodeAnalysis.LanguageServer; | ||
|
|
||
| internal record struct TrackedDocumentInfo(SourceText SourceText, string LanguageId, int LspVersion); |
CyrusNajmabadi
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client tells us the version of the text associated with each didOpen and didChange request. This PR updates our open document tracker to remember that version and allow subsequent requests to access the current snapshot's LSP version(s).
I'm planning on using this version in a followup on to improve scenarios where we send the client edits to apply (e.g. complex completion edits) to better track why edits may not be applying correctly.