Handle some scenarios where attributes applied in local functions or lambdas within extension blocks were missing in metadata #80464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lambdas within extension blocks were missing in metadata Related to dotnet#76130.
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
Contributor
Author
jjonescz
approved these changes
Sep 26, 2025
| static void validate(ModuleSymbol m) | ||
| { | ||
| AssertEx.SequenceEqual( | ||
| ["Preserve1Attribute"], |
Member
There was a problem hiding this comment.
Is there some spec for CompilerLoweringPreserve "feature" and does it mention that the attributes won't flow if the AttributeTargets are not compatible?
Contributor
Author
There was a problem hiding this comment.
Is there some spec for CompilerLoweringPreserve "feature" and does it mention that the attributes won't flow if the AttributeTargets are not compatible?
See #73920
Contributor
Author
|
@jcouv, @dotnet/roslyn-compiler For a second review. |
This was referenced Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #76130.