Skip to content

Block file-local EmbeddedAttribute definitions. #80501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Block file-local EmbeddedAttribute definitions. #80501

merged 1 commit into from
Sep 30, 2025

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Sep 29, 2025 •
edited
Loading

Closes #80105.

@333fred 333fred requested a review from a team as a code owner September 29, 2025 21:50
AlekseyTs
AlekseyTs approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@333fred 333fred merged commit 4f9e5ae into dotnet:main Sep 30, 2025
25 checks passed
@333fred 333fred deleted the block-field-embedded branch September 30, 2025 17:08
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 30, 2025
This was referenced Oct 4, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

No one assigned

Labels

Area-Compilers

Projects

None yet

Milestone

Next

Development

Successfully merging this pull request may close these issues.

No error is reported on EmbeddedAttribute with file accessibility

4 participants

@333fred @jjonescz @RikkiGibson @AlekseyTs