Show both property and extension method items with identical name#82315
Merged
genlu merged 3 commits intodotnet:mainfrom Feb 10, 2026
Merged
Show both property and extension method items with identical name#82315genlu merged 3 commits intodotnet:mainfrom
genlu merged 3 commits intodotnet:mainfrom
Conversation
…completion list Also for method + extension property.
genlu
force-pushed
the
FixExtensionItem
branch
from
f735992 to
85a92bd
Compare
JoeRobich
reviewed
Feb 6, 2026
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests.vb
Outdated
Show resolved
Hide resolved
genlu
force-pushed
the
FixExtensionItem
branch
from
85a92bd to
d4c818a
Compare
This was referenced Feb 9, 2026
JoeRobich
reviewed
Feb 9, 2026
| item = item.AddTag(WellKnownTags.TargetTypeMatch); | ||
| } | ||
| var includeItemInTargetTypedCompletion = false; | ||
| var arbitraryFirstContext = contextLookup(symbolList[0]); |
Member
There was a problem hiding this comment.
I know this code is preexisting, it is just odd to me to grab the first list item when we might reorder the list a few lines later. Perhaps a comment could be added explaining why the context is truly arbitrary.
Member
Author
There was a problem hiding this comment.
hmm, I'm actually not sure about this. Need to take a closer look to understand how it supposed to work with linked docs.🤔
JoeRobich
approved these changes
Feb 9, 2026
ToddGrun
reviewed
Feb 10, 2026
| completionContext, symbolGroup.Key.displayText, symbolGroup.Key.suffix, symbolGroup.Key.insertionText, symbolList, arbitraryFirstContext, supportedPlatformData); | ||
|
|
||
| if (includeItemInTargetTypedCompletion) | ||
| void CreateAndAddItem(ImmutableArray<SymbolAndSelectionInfo> symbolList, bool doNotMerge) |
Contributor
Contributor
There was a problem hiding this comment.
never mind, it wouldn't be simple. It looks like CreateItem takes in that collection and has several overrides that would need changing
Member
Author
There was a problem hiding this comment.
Yea, it'd ended up touching a lot more code than I intended in this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also for method + extension property.
Fix #70537