Conversation
…ects Why: Roslyn should consume the reviewed authoritative reader, generator, and build-task sources without maintaining a fork. What: - Apply 0 additions, 11 updates, and 0 deletions across the 6 projects. Mirror provenance: - Previous source: 21b9e352bb96cd02ed06276d05e53727a1c18143 - Current source: 265321feab881cd9c5ef75ccbeda9a8a42692688 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Attempt IDs can escape the cleanup root, and metadata-different duplicates are incorrectly treated as harmless.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Mirrors updated ProjectData build-task behavior, including sidecar slice isolation, diagnostic handling, and generated source inclusion.
Changes:
- Adds build-attempt-scoped slice discovery and merging.
- Improves diagnostic classification and deduplication.
- Expands task and targets regression coverage.
Two blocking issues were identified: unsafe attempt-ID path construction and suppression of actionable duplicate-metadata warnings.
| File | Description |
|---|---|
WriteProjectDataSliceTask.cs |
Demotes duplicate-item warnings. |
WriteProjectDataBuildReceiptTask.cs |
Adds project identity task. |
ProjectDataWriter.cs |
Hardens source-argument detection. |
ProjectDataMerger.cs |
Selects preferred and fallback slices. |
ProjectDataBuildCompletionLogger.cs |
Deduplicates and classifies diagnostics. |
MergeProjectDataSlicesTask.cs |
Discovers fallback slices. |
Microsoft.NET.ProjectData.targets |
Adds sidecar integration and attempt isolation. |
TaskExecutionTests.cs |
Tests logging and diagnostic behavior. |
TargetsFileSmokeTests.cs |
Tests targets integration scenarios. |
ProjectDataWriterTests.cs |
Tests invalid path characters. |
ProjectDataMergerTests.cs |
Tests fallback-slice selection. |
| <_ProjectDataOuterBuildActive>true</_ProjectDataOuterBuildActive> | ||
| <!-- DispatchToInnerBuilds reads $(InnerTargets) and forwards it to each inner build. --> | ||
| <InnerTargets Condition="'$(InnerTargets)' == ''">$(_ProjectDataBuildInnerTargets)</InnerTargets> | ||
| <_ProjectDataBuildAttemptSliceRoot Condition="'$(_ProjectDataBuildAttemptProjectId)' != ''">$(BaseIntermediateOutputPath)$(Configuration)/.csdevkit/projectdata-attempts/$(ProjectDataBuildReceiptAttemptId)/$(_ProjectDataBuildAttemptProjectId)</_ProjectDataBuildAttemptSliceRoot> |
Comment on lines
+231
to
+235
| // The writer deterministically keeps one equivalent item and still produces a valid | ||
| // cache. Keep the normalization in the binlog for product diagnosis, but do not emit | ||
| // an MSBuild warning: customers cannot act on it and retrying ProjectDataBuild cannot | ||
| // change the evaluated duplicate. | ||
| this.Log.LogMessage( |
emaf
approved these changes
Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is 100% AI generated
Why
Roslyn should consume the latest reviewed ProjectData reader, generator, and build-task state from vs-green without forking shared behavior.
What
Provenance
21b9e352bb96cd02ed06276d05e53727a1c18143265321feab881cd9c5ef75ccbeda9a8a426926888bd473fe7df62aaf8117a37a162c1fb4ee398ba5Validation
Microsoft Reviewers: Open in CodeFlow