Skip to content

Scope daemon telemetry isolation assertion to hover metrics - #85855

Draft
jaredpar with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-daemon-isolated-telemetry-session
Draft

jaredpar with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-daemon-isolated-telemetry-session

Conversation

Copilot AI commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Daemon_EachServerHasAnIsolatedTelemetrySession intermittently fails on main because it expects the second server to have recorded no metrics. That server can independently record initialization metrics while the first handles a hover request.

  • Assertion: Filter the second server’s recorded metrics by LSP method, so the isolation check measures hover telemetry rather than all server activity.
  • Regression coverage: Have the second server handle its own hover request and assert that its sink records it.
Original prompt

Test Failure: Daemon_EachServerHasAnIsolatedTelemetrySession

Failure Details

  • Test: Daemon_EachServerHasAnIsolatedTelemetrySession
  • Repository: dotnet/roslyn
  • Build: #1618416
  • Run: Test Linux Debug
  • Failed in: 5 build(s)

Error Message

Assert.Equal() Failure: Values differ
Expected: 0
Actual:   1

Stack Trace

   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LanguageServerDaemonTests.Daemon_EachServerHasAnIsolatedTelemetrySession() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/Daemon/LanguageServerDaemonTests.cs:line 150
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LanguageServerDaemonTests.Daemon_EachServerHasAnIsolatedTelemetrySession() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/Daemon/LanguageServerDaemonTests.cs:line 165
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LanguageServerDaemonTests.Daemon_EachServerHasAnIsolatedTelemetrySession() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/Daemon/LanguageServerDaemonTests.cs:line 165
--- End of stack trace from previous location ---

Instructions

This is failing regularly in main, please suggest a fix here

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test failure for Daemon_EachServerHasAnIsolatedTelemetrySession Scope daemon telemetry isolation assertion to hover metrics Sep 30, 2026
Copilot AI requested a review from jaredpar September 30, 2026 21:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants