Unify Razor diagnostics to a single endpoint - #85867
Open
davidwengier wants to merge 2 commits into
Open
davidwengier wants to merge 2 commits into
davidwengier wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The cross-host refactor appears coherent, but relevant CI and targeted validation have not completed.
Review effort: Balanced
Findings: None
What changed in this PR
Unifies Razor pull diagnostics behind one shared endpoint while retaining host-specific registration and behavior.
Changes:
- Replaces the generic base and two host endpoints with one capability-aware endpoint.
- Moves common tests into the shared suite and adds host-specific metadata checks.
- Separates VS and VS Code dynamic registration.
| File | Description |
|---|---|
Microsoft.VisualStudioCode.RazorExtension.UnitTests/.../CohostDocumentPullDiagnosticsTest.cs |
Adds VS Code metadata validation. |
Microsoft.VisualStudio.LanguageServices.Razor.UnitTests/.../CohostDocumentPullDiagnosticsTest.cs |
Retains VS-specific tests and metadata validation. |
Microsoft.CodeAnalysis.Razor.CohostingShared.UnitTests/.../CohostDocumentPullDiagnosticsTest.cs |
Centralizes shared endpoint tests and helpers. |
Microsoft.VisualStudioCode.RazorExtension/.../DocumentPullDiagnosticsRegistration.cs |
Adds VS Code diagnostic registration. |
Microsoft.VisualStudioCode.RazorExtension/.../DocumentPullDiagnosticsEndpoint.cs |
Removes the VS Code-specific endpoint. |
Microsoft.VisualStudio.LanguageServices.Razor/.../CohostDocumentPullDiagnosticsRegistration.cs |
Adds VS diagnostic registrations. |
Microsoft.VisualStudio.LanguageServices.Razor/.../CohostDocumentPullDiagnosticsEndpoint.cs |
Removes the VS-specific endpoint. |
Microsoft.CodeAnalysis.Razor.CohostingShared.projitems |
Includes the unified endpoint. |
.../CohostDocumentPullDiagnosticsEndpointBase.cs |
Removes the generic base endpoint. |
.../CohostDocumentPullDiagnosticsEndpoint.cs |
Implements unified capability-aware diagnostics. |
.github/memory/testing/razor.md |
Documents host-specific test placement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #85702
Now that all diagnostics are on public protocol types, we can simplify our implementation into one endpoint, rather than having a base class and two client-specific child classes with generics and other hoops.
Unfortunately the diff doesn't look great on GitHub because it doesn't recognize either endpoint deletion as being a rename. Sorry.
Microsoft Reviewers: Open in CodeFlow