Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The affected framework bootstrap validation and full CI run had not completed when reviewed.
Review effort: Balanced
Findings: None
What changed in this PR
Pins System.ClientModel to prevent conflicting source-generator versions in shared .NET Framework compiler-server builds.
Changes:
- Adds a central transitive pin for
System.ClientModel1.10.0. - Documents the framework bootstrap consistency requirement.
Holistic Assessment: The focused fix matches Roslyn’s central transitive-pinning model. No code issues found; targeted CI remains in progress.
| File | Description |
|---|---|
eng/Packages.props |
Unifies the System.ClientModel package and bundled generator version. |
Member
Author
|
@jasonmalinowski PTAL |
333fred
reviewed
Oct 2, 2026
Member
There was a problem hiding this comment.
Should we do a test insertion of this?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing rolling main roslyn-CI builds (leg Correctness_Bootstrap_Build_Framework), which started failing after #85748 (cc @jasonmalinowski).
Microsoft Reviewers: Open in CodeFlow