Increase grace period for BuildHost shutdown - #85881
Draft
mwiemer-microsoft wants to merge 2 commits into
Draft
mwiemer-microsoft wants to merge 2 commits into
mwiemer-microsoft wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Will investigate manually before sending to team |
mwiemer-microsoft
changed the title
mwiemer-microsoft
changed the title
mwiemer-microsoft
marked this pull request as ready for review
October 2, 2026 16:45
Member
Author
|
@RikkiGibson requesting review |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The timeout path can silently kill a genuinely stuck BuildHost, and the tests do not exercise that path.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Extends BuildHost shutdown tolerance, but incorrectly treats RPC completion as proof of process exit.
Changes:
- Increases shutdown grace period to five seconds.
- Suppresses timeout failures after an acknowledged shutdown request.
- Adds shutdown-related tests.
| File | Description |
|---|---|
BuildHostProcessManager.cs |
Adjusts timeout and failure reporting. |
BuildHostProcessManagerTests.cs |
Adds shutdown disposal tests. |
Comment on lines
+566
to
+573
| if (ShouldReportFailureOnShutdownTimeout(shutdownSucceeded)) | ||
| { | ||
| LogProcessFailure(); | ||
| } | ||
| else | ||
| { | ||
| _logger?.LogTrace("BuildHost did not exit after a successful shutdown request; terminating the process."); | ||
| } |
Comment on lines
+45
to
+50
| [Theory] | ||
| [InlineData(true, false)] | ||
| [InlineData(false, true)] | ||
| public void ShouldReportFailureOnShutdownTimeout(bool shutdownSucceeded, bool expected) | ||
| { | ||
| Assert.Equal(expected, BuildHostProcessManager.ShouldReportFailureOnShutdownTimeout(shutdownSucceeded)); |
dibarbet
reviewed
Oct 2, 2026
| [Theory] | ||
| [InlineData(true, false)] | ||
| [InlineData(false, true)] | ||
| public void ShouldReportFailureOnShutdownTimeout(bool shutdownSucceeded, bool expected) |
Member
There was a problem hiding this comment.
I don't think we should necessarily be testing this. It seems like its just testing a log, and the log depends only on timeout and could just make this super flaky.
| if (!_process.HasExited) | ||
| { | ||
| LogProcessFailure(); | ||
| if (ShouldReportFailureOnShutdownTimeout(shutdownSucceeded)) |
Member
There was a problem hiding this comment.
Is this change actually necessary? Seems like we're just changing log behavior and not really anything else?
mwiemer-microsoft
marked this pull request as draft
October 2, 2026 18:32
Member
Author
|
(marking draft: reviewing value of this PR as a separate fix from #85853 and other related PRs) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-10-01.12 roslyn-CI against main (expires ~2026-10-09, see attachments for persistent logs)
Runs fail sporadically if BuildHost shuts down slowly due to process load. This PR increases timeout from 500 ms to 5,000 ms (5 seconds) and adds a check for the BuildHost exit code on grace period expiry.
This is distinct from #85853: the failure addressed here comes from the process-disposal timeout during BuildHost restart/shutdown, not the manager's unexpected-disconnect callback.
Full attachment for indexing:
Microsoft Reviewers: Open in CodeFlow