Baseline new warning in trimming tests (#114424)

MichalStrehovsky · web-flow · commit 2f858e085f2d · 2025-04-09T22:47:28.000+02:00
ToolsTests legs are failing: #114406 (comment) Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs
@@ -30,6 +30,7 @@ class InvocationOnDynamicType
 		{
 			[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember")]
 			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
+			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 			static void DynamicArgument ()
 			{
 				dynamic dynamicObject = "Some string";
@@ -49,6 +50,7 @@ static void MethodWithDynamicParameterDoNothing (dynamic arg)
 
 			[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember")]
 			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
+			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 			static void MethodWithDynamicParameter (dynamic arg)
 			{
 				arg.MethodWithDynamicParameter (arg);
@@ -82,13 +84,15 @@ class DynamicMemberReference
 		{
 			[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.GetMember")]
 			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
+			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 			static void Read (dynamic d)
 			{
 				var x = d.Member;
 			}
 
 			[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.SetMember")]
 			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
+			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 			static void Write (dynamic d)
 			{
 				d.Member = 0;
@@ -105,13 +109,15 @@ class DynamicIndexerAccess
 		{
 			[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.GetIndex")]
 			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
+			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 			static void Read (dynamic d)
 			{
 				var x = d[0];
 			}
 
 			[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.SetIndex")]
 			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
+			[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 			static void Write (dynamic d)
 			{
 				d[0] = 0;
@@ -129,6 +135,7 @@ class DynamicInRequiresUnreferencedCodeClass
 			[RequiresUnreferencedCode("message")]
 			class ClassWithRequires
 			{
+				[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 				[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
 				public static void MethodWithDynamicArg (dynamic arg)
 				{

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ class InvocationOnDynamicType`
`30`	`30`	`{`
`31`	`31`	`[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember")]`
`32`	`32`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
	`33`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`33`	`34`	`static void DynamicArgument ()`
`34`	`35`	`{`
`35`	`36`	`dynamic dynamicObject = "Some string";`
`@@ -49,6 +50,7 @@ static void MethodWithDynamicParameterDoNothing (dynamic arg)`
`49`	`50`
`50`	`51`	`[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember")]`
`51`	`52`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
	`53`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`52`	`54`	`static void MethodWithDynamicParameter (dynamic arg)`
`53`	`55`	`{`
`54`	`56`	`arg.MethodWithDynamicParameter (arg);`
`@@ -82,13 +84,15 @@ class DynamicMemberReference`
`82`	`84`	`{`
`83`	`85`	`[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.GetMember")]`
`84`	`86`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
	`87`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`85`	`88`	`static void Read (dynamic d)`
`86`	`89`	`{`
`87`	`90`	`var x = d.Member;`
`88`	`91`	`}`
`89`	`92`
`90`	`93`	`[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.SetMember")]`
`91`	`94`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
	`95`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`92`	`96`	`static void Write (dynamic d)`
`93`	`97`	`{`
`94`	`98`	`d.Member = 0;`
`@@ -105,13 +109,15 @@ class DynamicIndexerAccess`
`105`	`109`	`{`
`106`	`110`	`[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.GetIndex")]`
`107`	`111`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
	`112`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`108`	`113`	`static void Read (dynamic d)`
`109`	`114`	`{`
`110`	`115`	`var x = d[0];`
`111`	`116`	`}`
`112`	`117`
`113`	`118`	`[ExpectedWarning ("IL2026", "Microsoft.CSharp.RuntimeBinder.Binder.SetIndex")]`
`114`	`119`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
	`120`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`115`	`121`	`static void Write (dynamic d)`
`116`	`122`	`{`
`117`	`123`	`d[0] = 0;`
`@@ -129,6 +135,7 @@ class DynamicInRequiresUnreferencedCodeClass`
`129`	`135`	`[RequiresUnreferencedCode("message")]`
`130`	`136`	`class ClassWithRequires`
`131`	`137`	`{`
	`138`	`+ [ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`132`	`139`	`[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]`
`133`	`140`	`public static void MethodWithDynamicArg (dynamic arg)`
`134`	`141`	`{`