Use 'ref readonly' in 'Unsafe.AsPointer' #114406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Note regarding the |
1 similar comment
|
Note regarding the |
Sergio0694
requested review from
tannergooding
and removed request for
MichalStrehovsky and
Copilot
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices |
This was referenced Apr 9, 2025
|
Failure in |
MichalStrehovsky
added a commit
that referenced
this pull request
Apr 9, 2025
ToolsTests legs are failing: #114406 (comment) Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
Likely fallout from a different PR that didn't run the Tools_Tests leg. Attempted a fix at #114424. |
MichalStrehovsky
added a commit
that referenced
this pull request
Apr 9, 2025
ToolsTests legs are failing: #114406 (comment) Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
Sergio0694
force-pushed
the
user/sergiopedri/unsafe-aspointer-refreadonly
branch
from
4c7f63d to
6d3a3b9
Compare
tannergooding
approved these changes
Apr 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114189
This PR updates the signature of
Unsafe.AsPointerto take aref readonlyinstead.