Skip to content

Commit 3696402

Browse files
am11gwr
authored andcommitted
Workaround gh-116929
1 parent 90d5fa3 commit 3696402

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

eng/Subsets.props

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@
5151
<_NativeAotSupportedArch Condition="'$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'arm' or '$(TargetArchitecture)' == 'loongarch64' or '$(TargetArchitecture)' == 'riscv64' or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86')">true</_NativeAotSupportedArch>
5252
<NativeAotSupported Condition="'$(_NativeAotSupportedOS)' == 'true' and '$(_NativeAotSupportedArch)' == 'true'">true</NativeAotSupported>
5353

54+
<_Crossgen2Supported Condition="'$(TargetOS)' != 'illumos' and '$(TargetOS)' != 'solaris'">true</_Crossgen2Supported>
55+
5456
<!-- Determine if we support running the .NET SDK on the target platform -->
5557
<_SdkToolsSupportedOS Condition="'$(TargetsMobile)' != 'true' and '$(TargetsLinuxBionic)' != 'true'">true</_SdkToolsSupportedOS>
5658
<_SdkToolsSupportedArch Condition="'$(TargetArchitecture)' != 'armel'">true</_SdkToolsSupportedArch>
@@ -440,7 +442,7 @@
440442
<ProjectToBuild Include="$(CoreClrProjectRoot).nuget\Microsoft.CrossOsDiag.Private.CoreCLR\Microsoft.CrossOsDiag.Private.CoreCLR.proj" Category="clr" />
441443
</ItemGroup>
442444

443-
<ItemGroup Condition="$(_subset.Contains('+clr.tools+'))">
445+
<ItemGroup Condition="$(_subset.Contains('+clr.tools+')) and '$(_Crossgen2Supported)' == 'true'">
444446
<ProjectToBuild Include="$(CoreClrProjectRoot)tools\runincontext\runincontext.csproj;
445447
$(CoreClrProjectRoot)tools\tieringtest\tieringtest.csproj;
446448
$(CoreClrProjectRoot)tools\r2rdump\R2RDump.csproj;
@@ -676,7 +678,7 @@
676678
<SharedFrameworkProjectToBuild Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Ref.sfxproj" />
677679
</ItemGroup>
678680
<ItemGroup>
679-
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono' and ('$(TargetsMobile)' != 'true' and '$(TargetsLinuxBionic)' != 'true')" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj" />
681+
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono' and ('$(TargetsMobile)' != 'true' and '$(TargetsLinuxBionic)' != 'true') and '$(_Crossgen2Supported)' == 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.sfxproj" />
680682
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' == '$(PrimaryRuntimeFlavor)' and '$(TargetsMobile)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-host.proj" />
681683
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' == '$(PrimaryRuntimeFlavor)' and '$(TargetsMobile)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-hostfxr.proj" />
682684
<SharedFrameworkProjectToBuild Condition="'$(RuntimeFlavor)' == '$(PrimaryRuntimeFlavor)' and '$(TargetsMobile)' != 'true'" Include="$(InstallerProjectRoot)pkg\sfx\installers\dotnet-runtime-deps\*.proj" />
@@ -691,7 +693,7 @@
691693
When we're building in the VMR, we need to provide a crossgen2 that runs on the host machine for downstream repos to use to R2R their code.
692694
In non-VMR builds, downstream repos can use the crossgen2 built for the target host SDK from another build leg, but in the VMR we need to provide one to use.
693695
-->
694-
<ProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono' and '$(TargetsMobile)' != 'true' and '$(TargetsLinuxBionic)' != 'true' and '$(BuildHostTools)' == 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.Host.sfxproj" Category="packs" />
696+
<ProjectToBuild Condition="'$(RuntimeFlavor)' != 'Mono' and '$(TargetsMobile)' != 'true' and '$(TargetsLinuxBionic)' != 'true' and '$(BuildHostTools)' == 'true' and '$(_Crossgen2Supported)' == 'true'" Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.Host.sfxproj" Category="packs" />
695697
</ItemGroup>
696698
<ItemGroup>
697699
<SharedFrameworkProjectToBuild Condition="'$(_BuildHostPack)' == 'true'" Include="$(InstallerProjectRoot)pkg\archives\dotnet-nethost.proj" />

eng/targetingpacks.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
LatestRuntimeFrameworkVersion="$(ProductVersion)"
4545
RuntimeFrameworkName="$(LocalFrameworkOverrideName)"
4646
RuntimePackNamePatterns="$(LocalFrameworkOverrideName).Runtime.**RID**"
47-
RuntimePackRuntimeIdentifiers="linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm64;win-x64;win-x86;linux-musl-arm;osx-arm64;maccatalyst-x64;maccatalyst-arm64;linux-s390x;linux-bionic-arm;linux-bionic-arm64;linux-bionic-x64;linux-bionic-x86;freebsd-x64;freebsd-arm64;linux-ppc64le;linux-riscv64;linux-musl-riscv64;linux-loongarch64;linux-musl-loongarch64"
47+
RuntimePackRuntimeIdentifiers="linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm64;win-x64;win-x86;linux-musl-arm;osx-arm64;maccatalyst-x64;maccatalyst-arm64;linux-s390x;linux-bionic-arm;linux-bionic-arm64;linux-bionic-x64;linux-bionic-x86;freebsd-x64;freebsd-arm64;illumos-x64;solaris-x64;linux-ppc64le;linux-riscv64;linux-musl-riscv64;linux-loongarch64;linux-musl-loongarch64"
4848
TargetFramework="$(NetCoreAppCurrent)"
4949
TargetingPackName="$(LocalFrameworkOverrideName).Ref"
5050
TargetingPackVersion="$(ProductVersion)"

src/installer/pkg/projects/netcoreappRIDs.props

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@
99
<OfficialBuildRID Include="osx-arm64">
1010
<Platform>arm64</Platform>
1111
</OfficialBuildRID>
12-
<!-- Not currently built by CoreFX. -->
13-
<!-- <OfficialBuildRID Include="netbsd-x64" /> -->
14-
<!-- <OfficialBuildRID Include="illumos-x64" /> -->
15-
<!-- <OfficialBuildRID Include="solaris-x64" /> -->
16-
<!-- <OfficialBuildRID Include="haiku-x64" /> -->
1712
<OfficialBuildRID Include="win-x86">
1813
<Platform>x86</Platform>
1914
</OfficialBuildRID>
@@ -51,6 +46,10 @@
5146
in our runtime.json to enable others to provide them. -->
5247
<UnofficialBuildRID Include="freebsd-x64" />
5348
<UnofficialBuildRID Include="freebsd-arm64" />
49+
<UnofficialBuildRID Include="illumos-x64" />
50+
<UnofficialBuildRID Include="solaris-x64" />
51+
<UnofficialBuildRID Include="netbsd-x64" />
52+
<UnofficialBuildRID Include="haiku-x64" />
5453
<UnofficialBuildRID Include="tizen.4.0.0-armel">
5554
<Platform>armel</Platform>
5655
</UnofficialBuildRID>

0 commit comments

Comments
 (0)