Bootstrap is failing on platform without AOT support

[am11]

On platforms where AOT is not supported, --use-bootstrap fails with error like: #105403 (comment).

This is because PublishSingleFile is not respecting bootstrapped singlefile:

$ ls artifacts/bootstrap/illumos-x64/host/
apphost  singlefilehost

Repro:

$ git clone https://github.com/gwr/dotnet-runtime runtime --branch illumos5 --single-branch --depth 1
$ docker run --rm -v$(pwd)/runtime:/runtime -e ROOTFS_DIR=/crossrootfs/x64 \
    -it mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-illumos

$ /runtime/build.sh clr+libs+packs -c Debug -os illumos -cross -gcc --bootstrap
...
Cleaning up artifacts from bootstrap build...
  Determining projects to restore...
  Tool 'coverlet.console' (version '6.0.4') was restored. Available commands: coverlet
  Tool 'dotnet-reportgenerator-globaltool' (version '5.4.3') was restored. Available commands: reportgenerator
  Tool 'microsoft.dotnet.xharness.cli' (version '10.0.0-prerelease.25255.1') was restored. Available commands: xharness
  Tool 'microsoft.visualstudio.slngen.tool' (version '12.0.15') was restored. Available commands: slngen
  
  Restore was successful.
  All projects are up-to-date for restore.
  Determining projects to restore...
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]
/runtime/.dotnet/sdk/10.0.100-preview.6.25302.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(188,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'illumos-x64'. [/runtime/Build.proj]

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

[am11]

cc @jkoritzinsky

@gwr here is a workaround am11@427f679. It fixes the restore issue but fails later in C++ code:

  [ 63%] Building CXX object jit/CMakeFiles/clrjit_win_x64_x64.dir/gcencode.cpp.o
  /runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp: In static member function 'static bool verbMerge::DirectoryFilterDirectories(FilterArgType*)':
  /runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp:188:19: error: 'verbMerge::FilterArgType' {aka 'struct dirent'} has no member named 'd_type'
    188 |     if (findData->d_type == DT_DIR)
        |                   ^~~~~~

so you can continue your work.

[gwr]

Thanks!

[gwr]

Looks like the code in verbmerge.cpp (or similar) will need some sort of configuration define conditional like DIRENT_HAS_D_TYPE set on Linux but not other Unix?
If dirent does not have d_type, the code could use stat(2) to get the type...
Or in this particular case, just remove the d_type == DT_DIR check. It's unnecessary.

[am11]

It was changed in #110797.

DIRENT_HAS_D_TYPE

We can deduplicate and use these checks:

$ git grep _D_TYPE                                
src/coreclr/hosts/corerun/config.h.in:#cmakedefine01 HAVE_DIRENT_D_TYPE
src/coreclr/hosts/corerun/configure.cmake:check_struct_has_member ("struct dirent" d_type dirent.h HAVE_DIRENT_D_TYPE)
src/coreclr/hosts/corerun/corerun.hpp:#if !HAVE_DIRENT_D_TYPE
src/coreclr/hosts/corerun/corerun.hpp:#if HAVE_DIRENT_D_TYPE
src/native/corehost/hostmisc/config.h.in:#cmakedefine01 HAVE_DIRENT_D_TYPE
src/native/corehost/hostmisc/configure.cmake:check_struct_has_member("struct dirent" d_type dirent.h HAVE_DIRENT_D_TYPE)
src/native/corehost/hostmisc/pal.unix.cpp:#if !HAVE_DIRENT_D_TYPE
src/native/corehost/hostmisc/pal.unix.cpp:#if HAVE_DIRENT_D_TYPE

[gwr]

Is there a quicker way to rebuild just this file?
/runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp

[am11]

Is there a quicker way to rebuild just this file?

grep -R 'g++.*verbmerge.cpp' artifacts/obj/coreclr/illumos.x64.Debug/ shows the raw command with relative paths, which you can execute from that location.

Generally, for quick build validation, we can use internal script src/coreclr/build-runtime.sh -cross -os illumos, completes in 2-3 mins on mac. It also takes -component <name> arg to limit the scope; what to build.