Q: System.Diagnostics.Activity out of proc monitoring value conversion culture variance

[CodeBlanch]

We can use DiagnosticSourceEventSource to listen to Activity \ traces out of proc. One of the things it does is normalize all tags (KeyValuePair<string, object?>) into strings (KeyValuePair<string, string?>).

Code:

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs

Line 1207 in aedb91f

return new KeyValuePair<string, string?>(_outputName, obj?.ToString());

Question: Should we use InvariantCulture when we do this?

Probably also the same question\issue for metrics and logs.

/cc @tarekgh @noahfalk @samsp-msft

[dotnet-policy-service]

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.