[cdac] Finish unimplemented parts of GetMethodDescData

[lambdageek]

This is a summary of TODO|FIXME|NotImplementedEx in src/native/managed/cdacreader:

• In CodeVersions_1:
  • IsActiveNativeCodeVersion needs to handle the NativeCodeVersionHandle::CodeVersionNodeAddress non-null case - by reading the NativeCodeVersionNode data and checking the IsActive field
  • FindActiveNativeCodeVersion needs to handle the !IsActiveNativeCodeVersion(node) case by iterating over the versioning state nodes
  • FindActiveNativeCodeVersion needs to handle the ILCodeVersionHandle::ILCodeVersionNode non-null case by examining the explicit IL code version
  • [cdac] Handle non-default active version and explicit IL code version cases for CodeVersions.GetActiveNativeCodeVersion #109560
• In ExecutionManager_1:
  • (big) ReadyToRunJitManager::GetMethodInfo needs to be implemented following ReadyToRunJitManager::JitCodeToMethodInfo in the C++ code.
    • [cdac] Implement ExecutionManager.ReadyToRunJitManager.GetMethodInfo (minus handling of hot/cold lookup) #109766
    • [cdac] Handle hot/cold map lookup in ExecutionManager.ReadyToRunJitManager.GetMethodInfo #110087
• In RuntimeTypeSystem_1:
  • In GetAddressOfSlot handle the slotNum > mt.NumVirtuals case of non-virtual slots allocated in front of MethodTableAuxiliaryData
    • [cdac] Handle non-default active version and explicit IL code version cases for CodeVersions.GetActiveNativeCodeVersion #109560
  • In GetLoaderModule handle type descs following TypeDesc::GetLoaderModule from the C++ code
    • [cdac] Handle type descs in RuntimeTypeSystem_1.GetLoaderModule #110325
  • In GetMethodClassificationDataType get the sizes for many non-IL method descriptors (FCall, PInvoke, EEImpl, ArrayMethod, ComInterp)
    • For GetMethodClassificationDataType verify that datadescriptor.h has definite sizes for all the MethodDesc subkinds
    • [cdac] Handle non-IL method descs in RuntimeTypeSystem_1.GetMethodClassificationDataType #110602
  • [cdac] Handle no method def token when trying to get the IL version state #110449
  • [cdac] Fix calculation of MethodDesc optional slot addresses #110491
• In SOSDacImpl::GetMethodDescData:
  • [cDAC] Implement ReJIT portion of SOSDacImpl::GetMethodDescData #109936 ReJIT Support
    • Handle filling out DacpMethodDescData fields around re-JIT: rejitDataCurrent, rejitDataRequested, cJittedReJitVersions
      • rejitDataCurrent and rejitDataRequested will require adding to the CodeVersion contract to get the version ID and re-JIT state for a NativeCodeVersionHandle
      • cJittedReJitVersions will require adding to the CodeVersion contract to get all re-JIT versions instead of just active
    • Handle the cRevertedRejitVersions != 0 requests
    • Handle the pcNeededRevertedRejitData != null requests
  • [cDAC] Implement GCCover portion of SOSDacImpl::GetMethodDescData #110322
    • Handle the HAVE_GCCOVER case and implement a GetGCCoverageInfo method for the NativeCode contract
  • Handle the bIsDynamic case [cDAC] SOSDacImpl::GetMethodDescData DynamicMethodObject #110545
    • Remove throw without implemented managedDynamicMethodObject
• In RuntimeTypeSystem_1 and MethodValidation: there are many // TODO(cdac): _ASSERTE (...) comments that include assertions that the C++ code had in the corresponding code. Implement them as Debug.Assert() or drop them.

[dotnet-policy-service]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.