SocketsHttpHandler.IsSupported is annotated as unsupported on browser

[marek-safar]

as it's a static property that is intended to be used for probing it should not be annotated as unsupported.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

as it's a static property that is intended to be used for probing it should not be annotated as unsupported.

Author:	marek-safar
Assignees:	-
Labels:	area-System.Net.Http, untriaged
Milestone:	-

[karelz]

@buyaa-n @jeffhandley would it make sense for analyzers to allow exclusion of IsSupported property?
The only alternative is to put the attribute on each member except the IsSupported -- which is kind of ugly.

[buyaa-n]

The only alternative is to put the attribute on each member except the IsSupported -- which is kind of ugly.

Right, maybe we leave the class annotation and add the new UnsupportedOSPlatformGuard("browser") attribute for this property which then can be used as a guard plus I will make sure it would not warn for UnsupportedOSPlatform("browser") attribute of containing type

[karelz]

@buyaa-n did you manage to add the new attribute? Or is it as least still in plan for 6.0?

[karelz]

@buyaa-n ping? cc @jeffhandley

[buyaa-n]

@buyaa-n did you manage to add the new attribute? Or is it as least still in plan for 6.0?

Yes the attribute is added and this is fixed, closing

runtime/src/libraries/System.Net.Http/ref/System.Net.Http.cs

Lines 362 to 363 in 4156116

	[System.Runtime.Versioning.UnsupportedOSPlatformGuardAttribute("browser")]
	public static bool IsSupported { get { throw null; } }