[release/9.0-preview5] Fix STJ support for System.Reflection.NullabilityInfoContext.IsSupported = false #102876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…rialization/OptionsTests.cs
…ion/Metadata/DefaultJsonTypeInfoResolver.Helpers.cs
ghost
added
the
eiriktsarpalis
approved these changes
May 30, 2024
jozkee
approved these changes
May 30, 2024
sebastienros
approved these changes
May 30, 2024
eiriktsarpalis
added
the
Servicing-consider
4 tasks
4 tasks
|
This wasn't working, I've described the problem here dotnet/sdk#41322 (comment) |
mkArtakMSFT
added
Servicing-approved
|
This was approved in Tactics. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #102852 to release/9.0-preview5
/cc @eiriktsarpalis
Customer Impact
.NET 9 Preview 5 added support for nullable reference types in System.Text.Json via #102499. The reflection-based serializer uses the
System.Reflection.NullabilityInfoContextclass to derive this metadata. What this change didn't anticipate is thatNullabilityInfoContextcan be disabled via a feature flag, and Blazor wasm disables that feature flag by default. This results in an exception being thrown every time Blazor wasm attempts to useJsonSerializerusing the reflection-based serializer.This PR adds checking for the
NullabilityInfoContextfeature flag so that the serializer can handle applications where the flag has been turned off.Regression
Yes
Testing
Added unit testing covering the impacted scenario.
Risk
Low.