Skip to content

Implement IUtf8SpanParsable on Char and Rune #105773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 1, 2025
Merged

Implement IUtf8SpanParsable on Char and Rune #105773

merged 9 commits into from
Jun 1, 2025

Conversation

lilinus
Copy link
Contributor

@lilinus lilinus commented Jul 31, 2024

Contributes to #81500

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Jul 31, 2024
@ghost
Copy link

ghost commented Jul 31, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jul 31, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 31, 2024
@huoyaoyuan huoyaoyuan added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 1, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

This was referenced Aug 1, 2024
Open
Closed
@am11 am11 requested review from stephentoub, eiriktsarpalis and a team October 6, 2024 10:45
This was referenced Jan 11, 2025
Open
Closed
stephentoub
stephentoub reviewed May 28, 2025
View reviewed changes
stephentoub
stephentoub reviewed May 28, 2025
View reviewed changes
stephentoub
stephentoub approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tannergooding?

@build-analysis build-analysis bot mentioned this pull request May 29, 2025
Open
@stephentoub stephentoub merged commit cb45af9 into dotnet:main Jun 1, 2025
137 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilinus @stephentoub @huoyaoyuan @tannergooding