[workload] Fix the SDK band version and base the WBT on the sdk flow by lewing · Pull Request #107899 · dotnet/runtime

lewing · 2024-09-16T23:09:27Z

No description provided.

akoeplinger · 2024-09-17T14:27:54Z

hmm I'm not sure this works without some of the other changes from the NET10 PR

lewing · 2024-09-17T14:33:15Z

hmm I'm not sure this works without some of the other changes from the NET10 PR

It doesn't work with them either, I was trying to illustrate the problem in dotnet/sdk#43070 to @marcpopMSFT

….1 sdk

lewing · 2024-09-17T15:27:19Z

hmm I'm not sure this works without some of the other changes from the NET10 PR

It doesn't work with them either, I was trying to illustrate the problem in dotnet/sdk#43070 to @marcpopMSFT

Just to make it more clear the SDK band version we're constructing right now in main is 9.0.100-alpha.1 which is very wrong, but using 10.0.100-alpha.1 won't work properly in a 9.0 sdk (even if we alter wbt to work). This PR now changes it to 9.0.0-rc.1 which should work here and will probably work in the SDK, at least sort of.

We might be able to reenable the multiple band logic and produce a 10.0.100-alpha.1 and a 9.0.100-rc.1 until the flow resolves? I want to make it clear again that putting the band version the package name was a bad choice and complicates all of this.

marcpopMSFT · 2024-09-17T16:51:22Z

Why can't you make it 10.0.0-alpha.1 like it's supposed to be? We should probably have already updated the stage0 SDK in the sdk PR to a 10.0.100 version which would make the workloads from runtime work, wouldn't it? Any reason we can't update stage zero sdk there?

lewing · 2024-09-17T17:12:26Z

Why can't you make it 10.0.0-alpha.1 like it's supposed to be? We should probably have already updated the stage0 SDK in the sdk PR to a 10.0.100 version which would make the workloads from runtime work, wouldn't it? Any reason we can't update stage zero sdk there?

Trying again with a recent 10.0.100 sdk

lewing · 2024-09-17T17:38:43Z

Why can't you make it 10.0.0-alpha.1 like it's supposed to be? We should probably have already updated the stage0 SDK in the sdk PR to a 10.0.100 version which would make the workloads from runtime work, wouldn't it? Any reason we can't update stage zero sdk there?

Trying again with a recent 10.0.100 sdk

@marcpopMSFT current failure is that the alpha.2 SDK only has workload sets which breaks our test setup

marcpopMSFT · 2024-09-17T18:38:44Z

@marcpopMSFT current failure is that the alpha.2 SDK only has workload sets which breaks our test setup

It has workload sets? You mean the baseline workload set is breaking the test setup somehow? CC @dsplaisted if that's the case to see if he has ideas on how we reversion in the workload set world.

src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs

lewing · 2024-09-17T19:03:07Z

@marcpopMSFT current failure is that the alpha.2 SDK only has workload sets which breaks our test setup

It has workload sets? You mean the baseline workload set is breaking the test setup somehow? CC @dsplaisted if that's the case to see if he has ideas on how we reversion in the workload set world.

So far it was just expecting a directory that wasn't there. Hopefully I was just overly pessimistic, will see if I can get it working here.

marcpopMSFT · 2024-09-18T19:24:11Z

Any luck? What folder? Do we have an option of having wasm workloads broken for a short time in sdk so we can get the rest of the repo and net10 work working?

lewing · 2024-09-18T22:02:16Z

Any luck? What folder? Do we have an option of having wasm workloads broken for a short time in sdk so we can get the rest of the repo and net10 work working?

I had to flow some updates from emsdk which is not fast (see dotnet/dnceng#4111 ) but I'm trying again now

kasperk81 · 2024-09-19T17:58:12Z

I want to make it clear again that putting the band version the package name was a bad choice and complicates all of this.

too late to change it? if it's going to be a continuous pain, perhaps take a hit now?

radical · 2024-09-19T18:41:27Z

eng/testing/workloads-testing.targets

-    <!-- Required for running apps built with 9.0 sdk, but the sdk does
-         not yet support *running* with 9.0 sdk -->
-    <AdditionalSharedFrameworkToInstallArguments Include="-Version latest -Channel 8.0 -Quality daily" />
+    <!-- Required for running apps built with 10.0 sdk, but the sdk does


Changes in this file look good.

radical · 2024-09-19T18:41:36Z

src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs

+            if (!Directory.Exists(outputDir))
+            {
+                Log.LogMessage($"Could not find {name} directory at {outputDir}. Creating it..");
+                Directory.CreateDirectory(outputDir);
+            }
+


Changes in this file look good.

radical

The workload task+installation specific changes LGTM 👍

lewing · 2024-09-20T01:49:38Z

I've merged what was remaining of this into #106599 which is farther along now

dotnet-policy-service · 2024-09-21T08:57:46Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Fix the workload band version

bf3701a

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 16, 2024

dotnet-policy-service bot assigned lewing Sep 16, 2024

lewing requested review from akoeplinger and steveisok September 16, 2024 23:13

lewing mentioned this pull request Sep 16, 2024

Merge the net10 runtime, aspnetcore, windowsdesktop, and arcade codeflows dotnet/sdk#43070

Merged

Fake the workload version suffix to something that will work in an rc…

78a563c

….1 sdk

lewing changed the title ~~Fix the workload band version~~ [workload] Fake the workload band version until we have a proper net10 sdk Sep 17, 2024

lewing requested a review from marcpopMSFT September 17, 2024 15:29

lewing added 2 commits September 17, 2024 12:00

Try 10.0.100-alpha.1 with a newer SDK

3b96f0c

Merge branch 'main' into net10-manifests

5d81ca6

build-analysis bot mentioned this pull request Sep 17, 2024

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Closed

3 tasks

lewing changed the title ~~[workload] Fake the workload band version until we have a proper net10 sdk~~ [workload] Fix the SDK band version and base the WBT on the sdk flow Sep 17, 2024

Create the manifest directory if it doesn't exist

fe1126f

lewing commented Sep 17, 2024

View reviewed changes

src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs Outdated Show resolved Hide resolved

Update src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs

af433b4

lewing added 2 commits September 17, 2024 19:24

Update to a proper net10 emsdk

40388cf

Add the emscripten dep back

5721b99

Bump emsdk again

30604fa

lewing added 3 commits September 18, 2024 17:19

Also install 9.0 to keep things working

852049e

Update the emsdk trigger too

807f56c

Update sdk refs

030d5d3

lewing mentioned this pull request Sep 18, 2024

Unable to checkout dotnet/dnceng#4115

Open

3 tasks

This was referenced Sep 19, 2024

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

[browser] Connection refused in 127.0.0.1 #104349

Closed

lewing added 2 commits September 19, 2024 12:31

Keep net8 too

a1166ce

Install aspnetcore runtime for downlevel too

29926a3

lewing requested a review from radical September 19, 2024 18:30

radical reviewed Sep 19, 2024

View reviewed changes

steveisok approved these changes Sep 19, 2024

View reviewed changes

radical approved these changes Sep 19, 2024

View reviewed changes

Try with 10 here too

80d5bdc

build-analysis bot mentioned this pull request Sep 19, 2024

Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928

Open

3 tasks

Merge branch 'main' into net10-manifests

c15da6c

build-analysis bot mentioned this pull request Sep 20, 2024

GetAsync_ServerNeedsAuthAndNoCredential_StatusCodeUnauthorized got cancelled #108019

Open

am11 added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 21, 2024

Merge branch 'main' into net10-manifests

e7f3b7b

build-analysis bot mentioned this pull request Sep 24, 2024

[browser][WBT] Found existing build but it had failed. #108175

Closed

lewing closed this Sep 25, 2024

github-actions bot locked and limited conversation to collaborators Oct 26, 2024

Conversation

lewing commented Sep 16, 2024

Uh oh!

akoeplinger commented Sep 17, 2024

Uh oh!

lewing commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcpopMSFT commented Sep 17, 2024

Uh oh!

lewing commented Sep 17, 2024

Uh oh!

lewing commented Sep 17, 2024

Uh oh!

marcpopMSFT commented Sep 17, 2024 • edited by lewing Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lewing commented Sep 17, 2024

Uh oh!

marcpopMSFT commented Sep 18, 2024

Uh oh!

lewing commented Sep 18, 2024

Uh oh!

kasperk81 commented Sep 19, 2024

Uh oh!

radical Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

radical Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

lewing commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Sep 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lewing commented Sep 17, 2024 •

edited

Loading

lewing commented Sep 17, 2024 •

edited

Loading

marcpopMSFT commented Sep 17, 2024 •

edited by lewing

Loading

lewing commented Sep 20, 2024 •

edited

Loading