Skip to content

XML docs for LINQ Join, LeftJoin, RightJoin #111177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025
Merged

Conversation

roji
Copy link
Member

@roji roji commented Jan 7, 2025

@roji roji force-pushed the LeftJoinDocs branch 3 times, most recently from ec356f5 to a8e5a78 Compare January 13, 2025 12:44
@roji
Copy link
Member Author

roji commented Feb 4, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jeffhandley
Copy link
Member

@roji I updated the branch, which will also force rerunning the pipelines. As far as I can tell, there's only one remaining topic for the remarks, with an open question to @carlossanlop.

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the questions have been answered. We need the porting tool to manually port docs to dotnet-api-docs and we're satisfied that <code> blocks are supported.

@eiriktsarpalis
Copy link
Member

/ba-g CI timeouts.

@eiriktsarpalis eiriktsarpalis enabled auto-merge (squash) May 20, 2025 14:15
@eiriktsarpalis eiriktsarpalis merged commit 7f07602 into dotnet:main May 20, 2025
79 of 85 checks passed
SimaTian pushed a commit that referenced this pull request May 27, 2025
* XML docs for LINQ Join, LeftJoin, RightJoin

See #110872 (comment)

* Remove nullability annotations in the docs

* Fix some incorrect xml code references

* Correct sample method names

* Correct summaries

---------

Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Eirik Tsarpalis <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants