Skip to content

Remove Windows 8.1 from test queues #112056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

agocke
Copy link
Member

@agocke agocke commented Jan 31, 2025

Windows 8.1 is EOL

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@xtqqczze
Copy link
Contributor

xtqqczze commented Feb 1, 2025

Windows 8.1 is EOL

Do we have test coverage for Windows Server 2012/R2, as it is still supported?

@agocke
Copy link
Member Author

agocke commented Feb 3, 2025

2012 R2 is only supported via ESU and there are currently no public ESU machines available. We will have to rely on separate validation.

@agocke
Copy link
Member Author

agocke commented Feb 3, 2025

cc @ViktorHofer

@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label Feb 7, 2025
@ViktorHofer
Copy link
Member

tell-mode - infra only change

@ViktorHofer ViktorHofer merged commit 6babc42 into dotnet:release/9.0-staging Feb 7, 2025
83 of 85 checks passed
@akoeplinger
Copy link
Member

/backport to release/8.0-staging

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13204487204

Copy link
Contributor

github-actions bot commented Feb 7, 2025

@akoeplinger backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Remove Windows 8.1 from test queues
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/helix-queues-setup.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/helix-queues-setup.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/helix-queues-setup.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Remove Windows 8.1 from test queues
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

akoeplinger added a commit that referenced this pull request Feb 7, 2025
akoeplinger added a commit that referenced this pull request Feb 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants