Skip to content

Conversation

@haruna99
Copy link

Fixes Issue dotnet/arcade#15562

Description

This PR solves the SBOM generation issue in the runtime repo

@haruna99 haruna99 added Servicing-approved Approved for servicing release area-Meta labels Mar 14, 2025
@haruna99 haruna99 requested a review from hoyosjs March 14, 2025 00:03
@haruna99 haruna99 self-assigned this Mar 14, 2025
Copilot AI review requested due to automatic review settings March 14, 2025 00:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the SBOM generation issue by updating the runtime release/8.0 branch to generate SBOMs after artifact signing.

  • Disabled SBOM generation at the job template level
  • Introduced an explicit SBOM generation step using a dedicated template

/bl:$(Build.SourcesDirectory)\prepare-artifacts.binlog
displayName: Prepare artifacts and upload to build
- template: /eng/common/templates-official/steps/generate-sbom.yml
Copy link

Copilot AI Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a displayName property to this SBOM generation step for improved clarity in pipeline logs.

Copilot uses AI. Check for mistakes.
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@hoyosjs hoyosjs changed the title update runtime release/8.0 branch to produce SBOM after signing artifacts [release/8.0] produce SBOM after signing artifacts Mar 14, 2025
@carlossanlop
Copy link
Contributor

/ba-g the BadExit failures are known, writing not permitted. Based on @hoyosjs sign off, I'll merge.

@carlossanlop carlossanlop merged commit 160b2be into dotnet:release/8.0 Mar 14, 2025
177 of 183 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Meta Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants