Skip to content

JIT: Changes from #113440 with diffs #113559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

JIT: Changes from #113440 with diffs #113559

merged 2 commits into from
Mar 19, 2025

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Mar 15, 2025 •
edited
Loading

Extracted from #113440 in order to make refactoring in #113440 zero-diff (for simpler code review).

  • Removed O2K_CONST_LONG (not too useful even for 32bit) along with op2.lconVal
  • O2K_SUBRANGE has no diffs in Global Prop - made Local Prop only
  • optAssertionProp_LclVar relied on op1.lcl.num in Global Prop, but the contract to rely only on op1.vm

Diffs minor size & TP improvements.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 15, 2025
@EgorBo EgorBo changed the title Clean up with diffs JIT: Changes from #113440 with diffs Mar 15, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Mar 15, 2025
Open
@EgorBo
Copy link
Member Author

EgorBo commented Mar 17, 2025

PTAL @AndyAyersMS cc @dotnet/jit-contrib I've extract the changes with diffs into a separate PR to make #113440 refactoring zero-diff

@EgorBo EgorBo requested a review from AndyAyersMS March 17, 2025 18:25
@EgorBo EgorBo marked this pull request as ready for review March 17, 2025 18:25
@Copilot Copilot AI review requested due to automatic review settings March 17, 2025 18:25
Copilot
Copilot AI reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@EgorBo EgorBo merged commit 6a23f1c into dotnet:main Mar 19, 2025
113 checks passed
@EgorBo EgorBo deleted the extracted-assertprop-diffs branch March 19, 2025 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @AndyAyersMS