Skip to content

[WASI] fix trimming #114211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[WASI] fix trimming #114211

merged 1 commit into from
Apr 4, 2025

Conversation

pavelsavara
Copy link
Member

preview 2 trimming

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Apr 3, 2025
@pavelsavara pavelsavara self-assigned this Apr 3, 2025
@pavelsavara pavelsavara marked this pull request as ready for review April 3, 2025 14:44
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Apr 3, 2025
@Copilot Copilot AI review requested due to automatic review settings April 3, 2025 14:44
Copilot
Copilot AI reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.LibraryBuild.WASI.xml: Language not supported

This was referenced Apr 3, 2025
Open
Open
Closed
Closed
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

/ba-g CI timeout

@pavelsavara pavelsavara merged commit 6c1382b into dotnet:main Apr 4, 2025
143 of 148 checks passed
@pavelsavara pavelsavara deleted the wasip2_trimming branch April 4, 2025 05:48
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@lewing lewing lewing approved these changes

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono linkable-framework Issues associated with delivering a linker friendly framework os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @lewing