[release/9.0-staging] Fix ordering issue in interface trimming #114509
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
This was referenced Apr 11, 2025
|
Friendly reminder that code complete for the may release is next Monday April 14th. If you want this change included in that release, please take it to Tactics and merge the PR before EOD Monday. |
|
@sbomer friendly reminder that code complete is on Monday May 12th (2:00 PM Pacific) for the June Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before the deadline. |
|
@sbomer reminder that servicing code complete for 9.0.7 is today @ 3PM PST. |
jtschuster
approved these changes
Jun 9, 2025
This was referenced Jun 9, 2025
steveisok
approved these changes
Jun 10, 2025
sbomer
added
Servicing-approved
|
Marking this approved since it was approved over email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110098 to release/9.0-staging
ProcessMarkedTypesWithInterfaces can lead to additional interface methods being required, so those need to be marked (done by ProcessInterfaceMethods) even if nothing else happens to put new items in the queue.
/cc @sbomer
Customer Impact
Reported in #109850. Upon upgrade to .NET 9, application fails with
TypeLoadException.Regression
Regressed in .NET 9 which had substantial changes to the interface trimming logic.
Testing
Validated it fixes the customer-reported issue locally, and the fix has been in .NET 10 since April. Coming up with a small testcase was nontrivial due to the order dependence - given the scope of the change I believe manual validation is sufficient.
Risk
Low. The fix just ensures that we finish processing interface methods, but doesn't change any of the processing logic.