-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[wasm][interp] Jiterp packedsimd shifts #114669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
Fixes the recent regressions in dotnet/perf-autofiling-issues#53419 without disabling the aliased opcodes (reverts #114659) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/mono/browser/runtime/jiterpreter-trace-generator.ts:3691
- Consider adding targeted tests to validate the early bitmask branch logic in emit_simd_2 to ensure that both the bitmask and fallback paths are exercised.
const bitmask = bitmaskTable[index];
Fill in some of the Jiterp tables with the PackedSimd intrinsics so that both aliased and direct PackedSimd calls in the interpreter also benefit from the Jiterpreter. Also reenable the aliased opcodes now that they will share the jiterpreter optimizations.