Skip to content

[wasm][interp] Jiterp packedsimd shifts #114669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2025

Conversation

lewing
Copy link
Member

@lewing lewing commented Apr 15, 2025

Fill in some of the Jiterp tables with the PackedSimd intrinsics so that both aliased and direct PackedSimd calls in the interpreter also benefit from the Jiterpreter. Also reenable the aliased opcodes now that they will share the jiterpreter optimizations.

Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

@lewing lewing requested a review from kg April 15, 2025 03:04
@lewing
Copy link
Member Author

lewing commented Apr 15, 2025

Fixes the recent regressions in dotnet/perf-autofiling-issues#53419 without disabling the aliased opcodes (reverts #114659)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/mono/browser/runtime/jiterpreter-trace-generator.ts:3691

  • Consider adding targeted tests to validate the early bitmask branch logic in emit_simd_2 to ensure that both the bitmask and fallback paths are exercised.
const bitmask = bitmaskTable[index];

@lewing lewing merged commit 91d74fc into dotnet:main Apr 15, 2025
109 of 113 checks passed
@lewing lewing deleted the jiterp-packedsimd-shifts branch April 15, 2025 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants