Skip to content

[RISC-V] Integer min/max intrinsics #114687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2025
Merged

[RISC-V] Integer min/max intrinsics #114687

merged 8 commits into from
Apr 16, 2025

Conversation

tomeksowi
Copy link
Contributor

Intrinsify System.Math.Min/Max and emit appropriate instructions when Zbb is present.

Part of #84834, cc @dotnet/samsung

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@am11 am11 added the arch-riscv Related to the RISC-V architecture label Apr 15, 2025
@risc-vv
Copy link

risc-vv commented Apr 15, 2025 •
edited
Loading

Release-FX-tests FAILED

buildinfo.json
coreFX tests failed for unknown reason. Check buildinfo.json or gocd for more details.

RISC-V Release-FX-QEMU: 641541 / 656796 (97.68%) 

=======================
      passed: 641541
      failed: 1608
     skipped: 1668
      killed: 13647
------------------------
  TOTAL libs: 259
 TOTAL tests: 658464
   REAL time: 2h 27min 3s 402ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 352b114afdad8cdcbcbd9335c19a675d933f8617
CI: 8190771aee300f57bfd4ea40a5cc4708b40c98db
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

@risc-vv
Copy link

risc-vv commented Apr 15, 2025

340bbc1 is being scheduled for building and testing

GIT: 340bbc1816a903b579907633841e09284ee40d26
REPO: dotnet/runtime
BRANCH: main

SingleAccretion
SingleAccretion reviewed Apr 15, 2025
View reviewed changes
@risc-vv
Copy link

risc-vv commented Apr 15, 2025 •
edited
Loading

RISC-V Release-CLR-VF2: 9699 / 9747 (99.51%) 

=======================
      passed: 9699
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9817
 TOTAL tests: 9817
   REAL time: 1h 59min 52s 106ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 290655f64a3d3cb7abd18688e9eeffb3065c74cd
CI: 8190771aee300f57bfd4ea40a5cc4708b40c98db
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9691 / 9732 (99.58%) 

=======================
      passed: 9691
      failed: 21
     skipped: 85
      killed: 20
------------------------
  TOTAL libs: 9817
 TOTAL tests: 9817
   REAL time: 3h 5min 7s 904ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 290655f64a3d3cb7abd18688e9eeffb3065c74cd
CI: 8190771aee300f57bfd4ea40a5cc4708b40c98db
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 723503 / 734522 (98.50%) 

=======================
      passed: 723503
      failed: 1689
     skipped: 1677
      killed: 9330
------------------------
  TOTAL libs: 259
 TOTAL tests: 736199
   REAL time: 1h 16min 30s 690ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 290655f64a3d3cb7abd18688e9eeffb3065c74cd
CI: 8190771aee300f57bfd4ea40a5cc4708b40c98db
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

This was referenced Apr 15, 2025
Open
Open
Open
Open
Open
Open
Closed
tomeksowi
tomeksowi commented Apr 16, 2025
View reviewed changes
src/coreclr/jit/valuenumfuncs.h
Comment on lines +93 to +100
ValueNumFuncDef(Max, 2, true, false, false)
ValueNumFuncDef(MaxMagnitude, 2, true, false, false)
ValueNumFuncDef(MaxMagnitudeNumber, 2, true, false, false)
ValueNumFuncDef(MaxNumber, 2, true, false, false)
ValueNumFuncDef(Min, 2, true, false, false)
ValueNumFuncDef(MinMagnitude, 2, true, false, false)
ValueNumFuncDef(MinMagnitudeNumber, 2, true, false, false)
ValueNumFuncDef(MinNumber, 2, true, false, false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking them commutative should be the only source of diffs for non-RISC-V.

@risc-vv
Copy link

risc-vv commented Apr 16, 2025 •
edited
Loading

RISC-V Release-CLR-VF2: 9701 / 9749 (99.51%) 

=======================
      passed: 9701
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9819
 TOTAL tests: 9819
   REAL time: 2h 0min 7s 224ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 9a729fbce1b28427837e3b9ee864df32db417f57
CI: 2d916d20de463f9bba05ae71b3d1f37d439a8cb1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9701 / 9749 (99.51%) 

=======================
      passed: 9701
      failed: 28
     skipped: 70
      killed: 20
------------------------
  TOTAL libs: 9819
 TOTAL tests: 9819
   REAL time: 3h 22min 32s 759ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 9a729fbce1b28427837e3b9ee864df32db417f57
CI: 2d916d20de463f9bba05ae71b3d1f37d439a8cb1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 673077 / 697871 (96.45%) 

=======================
      passed: 673077
      failed: 1665
     skipped: 1530
      killed: 23129
------------------------
  TOTAL libs: 259
 TOTAL tests: 699401
   REAL time: 2h 28min 53s 602ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 9a729fbce1b28427837e3b9ee864df32db417f57
CI: 2d916d20de463f9bba05ae71b3d1f37d439a8cb1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

@build-analysis build-analysis bot mentioned this pull request Apr 16, 2025
Open
@BruceForstall
Copy link
Contributor

/ba-g unrelated failures

@BruceForstall BruceForstall merged commit 01108e8 into dotnet:main Apr 16, 2025
153 of 162 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SingleAccretion SingleAccretion SingleAccretion left review comments

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees

@tomeksowi tomeksowi

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomeksowi @risc-vv @BruceForstall @SingleAccretion @am11