Skip to content

Add custom exception handlers to generated COM wrappers #114828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 15, 2025
Merged

Add custom exception handlers to generated COM wrappers #114828

merged 15 commits into from
May 15, 2025

Conversation

dongle-the-gadget
Copy link
Contributor

Fixes #109522

@dongle-the-gadget
Add custom exception handler to COM Wrappers
08f039e 
This is an initial iteration to add custom exception handlers to
generated COM wrappers, through a new ExceptionToUnmanagedMarshaller
property in GeneratedComWrappersAttribute

Fix dotnet#109522
@ghost
Copy link

ghost commented Apr 19, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Apr 19, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 19, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@dongle-the-gadget
Copy link
Contributor Author

@dotnet-policy-service agree

@dongle-the-gadget dongle-the-gadget changed the title Add ExceptionToUnmanagedMarshaller to GeneratedComInterfaceAttribute Add custom exception handlers to generated COM wrappers Apr 19, 2025
@dongle-the-gadget
Copy VTable Index exception logic over
1a66148 
Resolves an issue with previous implementation, highlighted by Jeremy.
The previous implementation is overcomplicated and hooks into the
default exception logic, which is not ideal. This commit copies the
existing custom exception marshalling logic from the VTable stub
generator.
@dongle-the-gadget
Remove redundant marshaller in interface data
d5cef7e
@dongle-the-gadget
Remove redundant metadata name logic
5319da6
jkoritzinsky
jkoritzinsky reviewed Apr 19, 2025
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, but looking much better!

dongle-the-gadget and others added 2 commits April 19, 2025 11:25
This was referenced Apr 19, 2025
Open
Open
Open
Open
Closed
@dongle-the-gadget @AaronRobinsonMSFT
Remove extra colon
d9804bb 
Co-authored-by: Aaron Robinson <[email protected]>
@build-analysis build-analysis bot mentioned this pull request Apr 20, 2025
Open
@build-analysis build-analysis bot mentioned this pull request May 3, 2025
Open
5 tasks
jkoritzinsky
jkoritzinsky reviewed May 8, 2025
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Mark this as non-draft and we can do a final review. (Also get the new test passing everywhere, looks like there's failures).

@dongle-the-gadget dongle-the-gadget marked this pull request as ready for review May 9, 2025 00:13
jkoritzinsky
jkoritzinsky approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

dongle-the-gadget and others added 2 commits May 10, 2025 01:09
@dongle-the-gadget @AaronRobinsonMSFT
Flip exception marshaller cases
3839064 
This is to match the common scenario.

Co-authored-by: Aaron Robinson <[email protected]>
@dongle-the-gadget
Add custom exception marshaller test.
9d48967
@build-analysis build-analysis bot mentioned this pull request May 9, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request May 10, 2025
Closed
This was referenced May 14, 2025
Open
Open
@build-analysis build-analysis bot mentioned this pull request May 15, 2025
Open
@AaronRobinsonMSFT
Copy link
Member

Thanks!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 3197765 into dotnet:main May 15, 2025
90 of 93 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: allow exception marshallers via '[return: MarshalUsing]' on generated COM interfaces methods without '[PreserveSig]'
3 participants
@dongle-the-gadget @AaronRobinsonMSFT @jkoritzinsky