[RISC-V] Introduce Zbs #115335

tomeksowi · 2025-05-06T13:39:00Z

Single-bit instructions

Part of #84834, cc @dotnet/samsung

dotnet-policy-service · 2025-05-06T13:39:55Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

src/coreclr/inc/jiteeversionguid.h

risc-vv · 2025-05-06T14:43:59Z

RISC-V Release-CLR-QEMU: 9064 / 9094 (99.67%)

=======================
      passed: 9064
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9691
VIRTUAL time: 29h 37min 35s 909ms
   REAL time: 42min 51s 362ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 2eb54ac5eb825abb358b05a8147a6cd44a0c6f7f
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 284444 / 285527 (99.62%)

=======================
      passed: 284444
      failed: 1077
     skipped: 38
      killed: 6
------------------------
 TOTAL tests: 285565
VIRTUAL time: 26h 15min 16s 695ms
   REAL time: 1h 10min 48s 483ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 2eb54ac5eb825abb358b05a8147a6cd44a0c6f7f
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-VF2: 9063 / 9093 (99.67%)

=======================
      passed: 9063
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9690
VIRTUAL time: 10h 35min 3s 934ms
   REAL time: 47min 4s 120ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 2eb54ac5eb825abb358b05a8147a6cd44a0c6f7f
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 306037 / 307763 (99.44%)

=======================
      passed: 306037
      failed: 1717
     skipped: 38
      killed: 9
------------------------
 TOTAL tests: 307801
VIRTUAL time: 20h 48min 54s 449ms
   REAL time: 2h 16min 23s 389ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 2eb54ac5eb825abb358b05a8147a6cd44a0c6f7f
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs

risc-vv · 2025-05-07T08:51:27Z

RISC-V Release-CLR-QEMU: 9064 / 9094 (99.67%)

=======================
      passed: 9064
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9691
VIRTUAL time: 29h 32min 11s 822ms
   REAL time: 42min 50s 445ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 90aa3eea9f0daa94f2f9971e22dc3e3d802e1b79
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-VF2: 9064 / 9094 (99.67%)

=======================
      passed: 9064
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9691
VIRTUAL time: 10h 29min 21s 101ms
   REAL time: 46min 42s 468ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 90aa3eea9f0daa94f2f9971e22dc3e3d802e1b79
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 284102 / 284874 (99.73%)

=======================
      passed: 284102
      failed: 767
     skipped: 38
      killed: 5
------------------------
 TOTAL tests: 284912
VIRTUAL time: 26h 34min 26s 217ms
   REAL time: 1h 11min 32s 686ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 90aa3eea9f0daa94f2f9971e22dc3e3d802e1b79
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 508616 / 510336 (99.66%)

=======================
      passed: 508616
      failed: 1708
     skipped: 38
      killed: 12
------------------------
 TOTAL tests: 510374
VIRTUAL time: 21h 48min 58s 143ms
   REAL time: 2h 8min 53s 795ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 90aa3eea9f0daa94f2f9971e22dc3e3d802e1b79
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

This reverts commit 8bf36ca.

risc-vv · 2025-05-07T15:36:10Z

RISC-V Release-CLR-QEMU: 9064 / 9094 (99.67%)

=======================
      passed: 9064
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9691
VIRTUAL time: 29h 33min 31s 208ms
   REAL time: 42min 50s 391ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10e542fe505e520c70c1e3a02cdec5f19cfd01de
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-VF2: 9064 / 9094 (99.67%)

=======================
      passed: 9064
      failed: 2
     skipped: 597
      killed: 28
------------------------
 TOTAL tests: 9691
VIRTUAL time: 10h 51min 51s 566ms
   REAL time: 48min 16s 85ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10e542fe505e520c70c1e3a02cdec5f19cfd01de
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 284592 / 285652 (99.63%)

=======================
      passed: 284592
      failed: 1055
     skipped: 38
      killed: 5
------------------------
 TOTAL tests: 285690
VIRTUAL time: 27h 10min 33s 736ms
   REAL time: 1h 11min 22s 158ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10e542fe505e520c70c1e3a02cdec5f19cfd01de
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 306274 / 307994 (99.44%)

=======================
      passed: 306274
      failed: 1710
     skipped: 38
      killed: 10
------------------------
 TOTAL tests: 308032
VIRTUAL time: 20h 28min 28s 790ms
   REAL time: 2h 9min 32s 244ms
=======================

report.xml, report.md, failures.xml, testclr_details.tar.zst

Build information and commands

GIT: 10e542fe505e520c70c1e3a02cdec5f19cfd01de
CI: fb90762a15dc605159873a3c1988381b6a288350
REPO: tomeksowi/runtime
BRANCH: zbs
CONFIG: Release
LIB_CONFIG: Release

jakobbotsch

This look good to me. @tannergooding do you mind taking a look as well?

tomeksowi · 2025-11-18T12:18:00Z

This look good to me. @tannergooding do you mind taking a look as well?

@tannergooding can you take a look?

tomeksowi · 2025-12-03T09:07:00Z

@tannergooding @dotnet/jit-contrib PTAL if this PR needs more work before merge

am11 · 2025-12-03T22:56:08Z

Looks great with interesting codegen improvements: #115335 (comment). AOT tests against b13e577 are also passing: https://github.com/am11/CrossRepoCITesting/actions/runs/19909582556 👌

am11 · 2025-12-13T11:11:47Z

This look good to me. @tannergooding do you mind taking a look as well?

@jakobbotsch, just checking in in case their GitHub notifications aren’t coming through, could this be merged? It’s been in a limbo state for a while, and merging it would help move things forward. Thanks!

src/coreclr/jit/emitriscv64.cpp

src/coreclr/jit/gtlist.h

tannergooding

Changes LGTM. But there's a couple questions given

tomeksowi added 4 commits May 6, 2025 15:36

Detect Zbs

ca72510

Emitter

96762df

Test

53d04b3

bseti, binvi

2eb54ac

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 6, 2025

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 6, 2025

am11 added the arch-riscv Related to the RISC-V architecture label May 6, 2025

am11 reviewed May 6, 2025

View reviewed changes

src/coreclr/inc/jiteeversionguid.h Show resolved Hide resolved

rhuijben reviewed May 6, 2025

View reviewed changes

src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs Outdated Show resolved Hide resolved

clamp03 assigned tomeksowi May 7, 2025

tomeksowi added 3 commits May 7, 2025 09:52

Fix IntrinsicConstants Zbs flag

d66c4ef

Remove brace indent in JITEEVersionIdentifier

8bf36ca

Fix test

90aa3ee

tomeksowi added 2 commits May 7, 2025 13:18

binvi

2c35e03

Simplify ExtractShift test

7a4fd78

build-analysis bot mentioned this pull request May 7, 2025

Test System.Runtime.InteropServices.JavaScript.Tests.TimerTests.TestTimers failing with "setCounter: actual 12 expected 13" #115346

Closed

tomeksowi added 2 commits May 7, 2025 17:01

Simple bexti lowering

4c3a319

Revert "Remove brace indent in JITEEVersionIdentifier"

10e542f

This reverts commit 8bf36ca.

jakobbotsch approved these changes Oct 21, 2025

View reviewed changes

jakobbotsch requested a review from tannergooding October 21, 2025 12:54

Merge branch 'main' into zbs (resolve conflicts)

315f8c7

Merge branch 'main' into zbs (resolve conflicts)

1050e7d

This was referenced Nov 18, 2025

BinderTracingTest.ResolutionFlow times out #104670

Open

[browser] Wasm.Build.Tests timeout - Timed out after 10s waiting for 'WASM EXIT' #116697

Open

Sometimes the helix SDK uses GetWorkItemsAsync when workitems aren't done processing. dotnet/dnceng#6011

Open

tomeksowi added 2 commits November 24, 2025 15:50

Merge branch 'main' into zbs (resolve conflicts)

a7b88bf

Merge branch 'main' into zbs (resolve conflicts)

b13e577

am11 requested a review from jkotas December 8, 2025 20:16

Merge branch 'main' into zbs (resolve conflicts)

f2fe841

build-analysis bot mentioned this pull request Dec 9, 2025

Unable to pull image from mcr.microsoft.com #117164

Open

matouskozak mentioned this pull request Dec 9, 2025

iOS device not found in OSX.13.Amd64.Iphone.Open dotnet/dnceng#6440

Open

3 tasks

tannergooding reviewed Dec 13, 2025

View reviewed changes

src/coreclr/jit/emitriscv64.cpp Outdated Show resolved Hide resolved

tannergooding reviewed Dec 13, 2025

View reviewed changes

src/coreclr/jit/gtlist.h Show resolved Hide resolved

tannergooding approved these changes Dec 13, 2025

View reviewed changes

clean up emitIns_R_R_I checks

c43a8da

jakobbotsch merged commit 65e9497 into dotnet:main Dec 16, 2025
174 of 176 checks passed

namu-lee mentioned this pull request Dec 16, 2025

[RISC-V] Enable constant CSE in RISCV64 #121739

Open

[RISC-V] Introduce Zbs #115335

[RISC-V] Introduce Zbs #115335

Uh oh!

Conversation

tomeksowi commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented May 6, 2025

Uh oh!

Uh oh!

risc-vv commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

risc-vv commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

risc-vv commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakobbotsch left a comment

Choose a reason for hiding this comment

Uh oh!

tomeksowi commented Nov 18, 2025

Uh oh!

tomeksowi commented Dec 3, 2025

Uh oh!

am11 commented Dec 3, 2025

Uh oh!

am11 commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

tannergooding left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tomeksowi commented May 6, 2025 •

edited

Loading

risc-vv commented May 6, 2025 •

edited

Loading

risc-vv commented May 7, 2025 •

edited

Loading

risc-vv commented May 7, 2025 •

edited

Loading