Skip to content

[main] Source code updates from dotnet/dotnet #115545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 14, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

dotnet-maestro bot added 2 commits May 15, 2025 02:08
Updated Dependencies:
System.CommandLine (Version 2.0.0-beta5.25263.104 -> 2.0.0-beta5.25260.104)
Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25263.104 -> 0.11.5-alpha.25260.104)
Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.5.25263.104 -> 10.0.100-preview.5.25260.104)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25263.104 -> 10.0.0-beta.25260.104)
Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.2-beta.25263.104 -> 2.9.2-beta.25260.104)
Microsoft.NETCore.App.Runtime.win-x64, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.5.25263.104 -> 10.0.0-preview.5.25260.104)
Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25263.104 -> 5.0.0-1.25260.104)
Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25263.104 -> 10.0.0-preview.25260.104)
dotnet-maestro bot added 3 commits May 15, 2025 14:10
[[ commit created by automation ]]
Updated Dependencies:
System.CommandLine (Version 2.0.0-beta5.25263.108 -> 2.0.0-beta5.25260.104)
Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25263.108 -> 0.11.5-alpha.25260.104)
Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.5.25263.108 -> 10.0.100-preview.5.25260.104)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25263.108 -> 10.0.0-beta.25260.104)
Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.2-beta.25263.108 -> 2.9.2-beta.25260.104)
Microsoft.NETCore.App.Runtime.win-x64, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.5.25263.108 -> 10.0.0-preview.5.25260.104)
Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25263.108 -> 5.0.0-1.25260.104)
Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25263.108 -> 10.0.0-preview.25260.104)
dotnet-maestro bot added 3 commits May 16, 2025 07:18
[[ commit created by automation ]]
Updated Dependencies:
System.CommandLine (Version 2.0.0-beta5.25265.101 -> 2.0.0-beta5.25260.104)
Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25265.101 -> 0.11.5-alpha.25260.104)
Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.5.25265.101 -> 10.0.100-preview.5.25260.104)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25265.101 -> 10.0.0-beta.25260.104)
Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.2-beta.25265.101 -> 2.9.2-beta.25260.104)
Microsoft.NETCore.App.Runtime.win-x64, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.5.25265.101 -> 10.0.0-preview.5.25260.104)
Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25265.101 -> 5.0.0-1.25260.104)
Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25265.101 -> 10.0.0-preview.25260.104)
@akoeplinger
Copy link
Member

@dotnet/illink there's a new ILLink test failure:

Unexpected warnings were generated:

D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(142,6): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember(CSharpBinderFlags, String, IEnumerable<Type>, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.
D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(115,13): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.GetIndex(CSharpBinderFlags, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.
D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(123,5): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.SetIndex(CSharpBinderFlags, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.
D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(90,13): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.GetMember(CSharpBinderFlags, String, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.
D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(98,5): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.SetMember(CSharpBinderFlags, String, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.
D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(37,5): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember(CSharpBinderFlags, String, IEnumerable<Type>, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.
D:\a\_work\1\s\src\tools\illink\test\Mono.Linker.Tests.Cases\DataFlow\DynamicObjects.cs(56,5): warning IL3050: Using member 'Microsoft.CSharp.RuntimeBinder.Binder.InvokeMember(CSharpBinderFlags, String, IEnumerable<Type>, Type, IEnumerable<CSharpArgumentInfo>)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. The 'dynamic' feature requires runtime-code generation, which is incompatible with AOT.



Stack trace
   at ILLink.RoslynAnalyzer.Tests.TestChecker.Check(Boolean allowMissingWarnings) in D:\a\_work\1\s\src\tools\illink\test\ILLink.RoslynAnalyzer.Tests\TestChecker.cs:line 70
   at ILLink.RoslynAnalyzer.Tests.TestCaseUtils.RunTestFile(String suiteName, String testName, Boolean allowMissingWarnings, ValueTuple`2[] msbuildProperties) in D:\a\_work\1\s\src\tools\illink\test\ILLink.RoslynAnalyzer.Tests\TestCaseUtils.cs:line 79
--- End of stack trace from previous location ---

@agocke
Copy link
Member

agocke commented May 16, 2025

@sbomer Can you take a look? Probably pulling new ref assemblies

Updated Dependencies:
System.CommandLine (Version 2.0.0-beta5.25265.106 -> 2.0.0-beta5.25260.104)
Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25265.106 -> 0.11.5-alpha.25260.104)
Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.5.25265.106 -> 10.0.100-preview.5.25260.104)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25265.106 -> 10.0.0-beta.25260.104)
Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.2-beta.25265.106 -> 2.9.2-beta.25260.104)
Microsoft.NETCore.App.Runtime.win-x64, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.5.25265.106 -> 10.0.0-preview.5.25260.104)
Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25265.106 -> 5.0.0-1.25260.104)
Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25265.106 -> 10.0.0-preview.25260.104)
[[ commit created by automation ]]
@akoeplinger
Copy link
Member

akoeplinger commented May 21, 2025

hmm the code diff is containing a bunch of unexpected changes, closing and reopening: #115833

@akoeplinger akoeplinger deleted the darc-main-4fc5d187-e9ea-4258-9944-14f0a294a891 branch May 21, 2025 13:28
@akoeplinger
Copy link
Member

@premun mind double checking what happened here? thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants