[DRAFT] Use il offset walker instead of debugger data to gather the IL offset during stack trace generation #116031
+1,391
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This removes it from normal path - This also adds an assert that it is correct Logically, this code should probably replace the current implementation of GetILOffsetFromNative but this first pass is just to get the code working This is untested, but it does compile.
|
Tagging subscribers to this area: @tommcdon |
3 tasks
3 tasks
… chunks and doing very cheap operations per nibble read - Add a fixed size cache around the native to IL mapping operations in the stacktrace logic - Unfortunately, simply reading the nibble data is pretty slow, so this is needed to avoid regressing performance - With this change the performance of newing up a StackTrace object on a multithreaded environment is primarily driven by GC allocation rate, and not significantly by any other locks.
This was referenced May 29, 2025
Open
This was referenced Jun 18, 2025
This both generates less data (Experiments show about a 70KB reduction in size of System.Private.CoreLib.dll R2R image) And the reader as implemented here, is quite a bit faster When combined with the cache constructed in a different part of this PR, this results in the cost of IL offset determination for a given IP to have negligible cost.
jkotas
reviewed
Jun 23, 2025
| @@ -13215,6 +13216,9 @@ static TADDR UnsafeJitFunctionWorker( | |||
| if (g_pDebugInterface) | |||
| { | |||
| g_pDebugInterface->JITComplete(nativeCodeVersion, (TADDR)nativeEntry); | |||
| #ifdef DEBUG | |||
| ValidateILOffsets(ftn, NULL, 0, (uint8_t*)nativeEntry, sizeOfCode); | |||
There was a problem hiding this comment.
This offset validation is causing some tests to time out. Build analysis may be misclassifying some of these timeouts against unrelated known issues (e.g. #116748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a path for reading the IL-Native map which doesn't create a DebuggerFunctionInfo or DebuggerJitInfo
Use it in the stackwalker code for EH.
Draft because: