JIT: Consistently use TypeIs/OperIs for type/oper checks
#116141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
I would be more interested in replacing |
I can try adding that to this PR. There's also |
jakobbotsch
changed the title
TypeIs/OperIs for type/oper checks
|
PTAL @dotnet/jit-contrib |
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes type and operator checks across the JIT by introducing and using TypeIs and OperIs in place of direct TypeGet/gtType and OperGet/gtOper comparisons.
- Adds
LclVarDsc::TypeIs(and variadic overload) for succinct multi‐type checks - Replaces
OperGet() == ...withOperIs(...)everywhere - Replaces
gtType/TypeGet()checks withTypeIs(...)
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| emitriscv64.cpp | OperGet/gtType → OperIs/TypeIs in emitter logic |
| emitarm64.cpp, emitarm.cpp | Same replacements in ARM emitters |
| emit.cpp, earlyprop.cpp | Replaced legacy checks in codegen and early propagation |
| decomposelongs.cpp | Assertions on GT_LONG use OperIs |
| compiler.hpp, compiler.h, compiler.cpp | Added TypeIs and replaced type/operator checks |
| codegen*.cpp (xarch, risc-V, LoongArch, ARM) | Wide spread substitutions in code generators |
| block.cpp, async.cpp, assertionprop.cpp | Updated IR checks in flow/block and assertion props |
| codegencommon.cpp | Address mode and register mask logic updated |
EgorBo
approved these changes
Jun 2, 2025
Hmm, good question. In fact it does not repro for me locally... I get these results: Overall (-0.04% to +0.00%)
MinOpts (-0.15% to -0.07%)
FullOpts (-0.03% to +0.02%)
DetailsAll contexts:
MinOpts contexts:
FullOpts contexts:
I would expect that yes, it has to do with different inlining decisions, and it's probably quite sensitive to MSVC version. If that's the case it will change entirely with native PGO enabled. It also looks like there are no TP diffs with clang, so I will merge as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LclVarDsc::TypeIsTypeIsandOperIseverywhere (replacements done with a series of regex)