Skip to content

Remove unused double -> int/uint cast helpers #116484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

Remove unused double -> int/uint cast helpers #116484

merged 2 commits into from
Jun 11, 2025

Conversation

saucecontrol
Copy link
Member

Resolves #116401

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 10, 2025
@saucecontrol saucecontrol marked this pull request as ready for review June 10, 2025 17:52
@saucecontrol saucecontrol changed the title Remove double -> int/uint cast helpers Remove unused double -> int/uint cast helpers Jun 10, 2025
tannergooding
tannergooding approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are there any other R2R breaking changes or cleanup we want to get in at the same time?

CC. @jkotas

jkotas
jkotas approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented Jun 11, 2025

Are there any other R2R breaking changes or cleanup we want to get in at the same time?

I am not aware of any

@jkotas jkotas merged commit e82789b into dotnet:main Jun 11, 2025
100 checks passed
@saucecontrol saucecontrol deleted the remove-cast-helpers branch June 11, 2025 16:16
@jakobbotsch
Copy link
Member

jakobbotsch commented Jun 12, 2025 •
edited
Loading

Please cc @dotnet/jit-contrib on JIT changes, especially if they change JIT-EE GUID (this allows us to better keep track of the superpmi collections that will interfere with existing PRs.)

@jakobbotsch jakobbotsch mentioned this pull request Jun 12, 2025
Merged
@jkotas
Copy link
Member

jkotas commented Jun 12, 2025

Please cc @dotnet/jit-contrib on JIT changes, especially if they change JIT-EE GUID (this allows us to better keep track of the superpmi collections that will interfere with existing PRs.)

This is a job for automation: #116589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas approved these changes

@tannergooding tannergooding tannergooding approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove double -> int/uint cast helpers
4 participants
@saucecontrol @jkotas @jakobbotsch @tannergooding