Include the frame register when copying arm32 debugger stackwalk context #116663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for copying the frame register on ARM32 by enabling DT_CONTEXT_INTEGER when TARGET_ARM is defined, matching the existing behavior on AMD64.
- Expanded the
ContextFlagsmask to includeDT_CONTEXT_INTEGERfor ARM32. - Updated comments to explain why
DT_CONTEXT_INTEGERis required on ARM32 and AMD64.
Comments suppressed due to low confidence (2)
src/coreclr/debug/daccess/dacdbiimpl.cpp:5651
- [nitpick] Consider clarifying and formatting this comment to be more concise and aligned. For example:
// Include frame register on ARM32 and AMD64
| DT_CONTEXT_INTEGER| DT_CONTEXT_INTEGER // DT_CONTEXT_INTEGER is needed to include the frame register on ARM32 and AMD64 architectures
src/coreclr/debug/daccess/dacdbiimpl.cpp:5650
- Add or update unit tests to cover the ARM32 path and verify that
DT_CONTEXT_INTEGERis correctly set whenTARGET_ARMis defined.
#if defined(TARGET_AMD64) || defined(TARGET_ARM)
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
max-charlamb
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous change on #116617, I didn't include copying the frame pointer for arm32. This change enables DT_CONTEXT_INTEGER for arm32 in addition to the previously enabled amd64 architecture.
Fixes: #115668